* [PATCH] ARM: dts: rockchip: Add BT_EN to the power sequence for veyron
@ 2019-04-09 23:14 Matthias Kaehlcke
2019-04-10 20:59 ` Doug Anderson
2019-04-11 11:38 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2019-04-09 23:14 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
Add GPIO D5 (BT_ENABLE_L) as reset-GPIO to the power sequence for the
Bluetooth/WiFi module. On devices with a Broadcom module the signal
needs to be asserted to use Bluetooth.
Note that BT_ENABLE_L is a misnomer in the schematics, the signal
actually is active-high.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
arch/arm/boot/dts/rk3288-veyron.dtsi | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 0bc2409f6903..a4cd851dc313 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -62,12 +62,19 @@
pinctrl-0 = <&bt_enable_l>, <&wifi_enable_h>;
/*
- * On the module itself this is one of these (depending
- * on the actual card populated):
+ * Depending on the actual card populated GPIO4 D4 and D5
+ * correspond to one of these signals on the module:
+ *
+ * D4:
* - SDIO_RESET_L_WL_REG_ON
* - PDN (power down when low)
+ *
+ * D5:
+ * - BT_I2S_WS_BT_RFDISABLE_L
+ * - No connect
*/
- reset-gpios = <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>,
+ <&gpio4 RK_PD5 GPIO_ACTIVE_LOW>;
};
vcc_5v: vcc-5v {
--
2.21.0.392.gf8f6787159e-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add BT_EN to the power sequence for veyron
2019-04-09 23:14 [PATCH] ARM: dts: rockchip: Add BT_EN to the power sequence for veyron Matthias Kaehlcke
@ 2019-04-10 20:59 ` Doug Anderson
2019-04-11 11:38 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2019-04-10 20:59 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
open list:ARM/Rockchip SoC...,
devicetree, LKML, Douglas Anderson
Hi,
On Tue, Apr 9, 2019 at 4:14 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Add GPIO D5 (BT_ENABLE_L) as reset-GPIO to the power sequence for the
> Bluetooth/WiFi module. On devices with a Broadcom module the signal
> needs to be asserted to use Bluetooth.
>
> Note that BT_ENABLE_L is a misnomer in the schematics, the signal
> actually is active-high.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/arm/boot/dts/rk3288-veyron.dtsi | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Looks right to me. Thanks!
Note that this might enable the signals in a different order than in
the downstream Chrome OS kernel, but it looks like it doesn't matter
in this case since the datasheet for the AzureWave module talks about
enabling / disabling these pins in either order.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add BT_EN to the power sequence for veyron
2019-04-09 23:14 [PATCH] ARM: dts: rockchip: Add BT_EN to the power sequence for veyron Matthias Kaehlcke
2019-04-10 20:59 ` Doug Anderson
@ 2019-04-11 11:38 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2019-04-11 11:38 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Rob Herring, Mark Rutland, linux-arm-kernel, linux-rockchip,
devicetree, linux-kernel, Douglas Anderson
Am Mittwoch, 10. April 2019, 01:14:05 CEST schrieb Matthias Kaehlcke:
> Add GPIO D5 (BT_ENABLE_L) as reset-GPIO to the power sequence for the
> Bluetooth/WiFi module. On devices with a Broadcom module the signal
> needs to be asserted to use Bluetooth.
>
> Note that BT_ENABLE_L is a misnomer in the schematics, the signal
> actually is active-high.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
applied for 5.2 with Doug's rb.
Thanks
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-11 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 23:14 [PATCH] ARM: dts: rockchip: Add BT_EN to the power sequence for veyron Matthias Kaehlcke
2019-04-10 20:59 ` Doug Anderson
2019-04-11 11:38 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).