From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E99DC31E40 for ; Mon, 10 Jun 2019 16:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0279F206C3 for ; Mon, 10 Jun 2019 16:50:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NS6I1EfO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387444AbfFJQuX (ORCPT ); Mon, 10 Jun 2019 12:50:23 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:35445 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727648AbfFJQuW (ORCPT ); Mon, 10 Jun 2019 12:50:22 -0400 Received: by mail-io1-f65.google.com with SMTP id m24so7441030ioo.2 for ; Mon, 10 Jun 2019 09:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jigJfFRZkdX+fDWDB3Z6i7DXek+TxEO+iFMi0ontPyI=; b=NS6I1EfOS4Qln6O21W/qaWiFUMqu8lDW/jqsVurVgncwNQNmgiZ7ryVM5WNjFbA1tg 6okpyEoD7k4sfn32wuY4Hw3AvMOSF+FH1cyzQTqePdpEc4PxU4V1MR7kC4tb8xOzYBLB 9dcsOIODkMVEkDakGWmtbuSR/ZtezbmGzY+/k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jigJfFRZkdX+fDWDB3Z6i7DXek+TxEO+iFMi0ontPyI=; b=Fu7GkzLgEthB6+n4DTpETC/Vgcf66BWVTCOIJAkAuQykkGHZTHV2TR4jQiYKO+B6cN /YgR3z4MyMIS69Syza6o3YSmyHr8W/G83oAB6+wE/UcVuWye0ccrf5ckbztE7EofEojV yRVMG7Q6m7nrGccnrqR5jekf6H1f1OdNYnUieJnyjSgZW/aYU1ZS+W33pKFYdbw55cmC E82z8AAEC4I5sRTEEacFi5YogEBd5JnT6iekV8fvB7frXc28qZJUdmVM46APGjWKEcUB YVvc/nGeEAnXYdDckLq+g/AoCcYLRSeC9IpEYWrqJyJGc+YtWa8s77VwVVvXPVuhl/ed W3NQ== X-Gm-Message-State: APjAAAVgadgFRkD2jHlWV5kd+8vJtfKaoEkIQMX0SZ75hxWqXCJMzf8E DIRjyEZO4hxX4wd+OT3+UvWedHDgkFg= X-Google-Smtp-Source: APXvYqwXL7a7Wcn4wiXf2O/2ZACFP297WuyPZWUN/PRvfmbHQo7QUlNm+WOsj5n/VX3F4MxaJjd+bg== X-Received: by 2002:a6b:8e4a:: with SMTP id q71mr41532593iod.298.1560185421514; Mon, 10 Jun 2019 09:50:21 -0700 (PDT) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com. [209.85.166.47]) by smtp.gmail.com with ESMTPSA id a7sm3840022iok.19.2019.06.10.09.50.20 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2019 09:50:20 -0700 (PDT) Received: by mail-io1-f47.google.com with SMTP id k20so7401537ios.10 for ; Mon, 10 Jun 2019 09:50:20 -0700 (PDT) X-Received: by 2002:a6b:b642:: with SMTP id g63mr8234768iof.142.1560185419663; Mon, 10 Jun 2019 09:50:19 -0700 (PDT) MIME-Version: 1.0 References: <20190607223716.119277-1-dianders@chromium.org> <20190607223716.119277-4-dianders@chromium.org> <363DA0ED52042842948283D2FC38E4649C52F8A0@IRSMSX106.ger.corp.intel.com> In-Reply-To: <363DA0ED52042842948283D2FC38E4649C52F8A0@IRSMSX106.ger.corp.intel.com> From: Doug Anderson Date: Mon, 10 Jun 2019 09:50:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail To: "Hunter, Adrian" Cc: Ulf Hansson , Kalle Valo , Arend van Spriel , "brcm80211-dev-list.pdl@broadcom.com" , "linux-rockchip@lists.infradead.org" , Double Lo , "briannorris@chromium.org" , "linux-wireless@vger.kernel.org" , Naveen Gupta , Madhan Mohan R , "mka@chromium.org" , Wright Feng , Chi-Hsien Lin , "netdev@vger.kernel.org" , "brcm80211-dev-list@cypress.com" , Franky Lin , "linux-kernel@vger.kernel.org" , Hante Meuleman , YueHaibing , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jun 10, 2019 at 1:56 AM Hunter, Adrian wrote: > > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > @@ -16,6 +16,7 @@ > > #include > > #include > > #include > > +#include > > SDIO function drivers should not really include linux/mmc/core.h > (Also don't know why linux/mmc/card.h is included) OK, so I guess you're requesting an extra level of "sdio_" wrappers for all the functions I need to call. I don't think the wrappers buy us a ton other than to abstract things a little bit and make it look prettier. :-) ...but certainly I can code that up if that's what everyone wants. Just to make sure, I looked in "drivers/net/wireless/" and I do see quite a few instances of "mmc_" functions being used. That doesn't mean all these instances are correct but it does appear to be commonplace. Selected examples: drivers/net/wireless/ath/ath10k/sdio.c: ret = mmc_hw_reset(ar_sdio->func->card->host); drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: mmc_set_data_timeout(md, func->card); mmc_wait_for_req(func->card->host, mr); drivers/net/wireless/marvell/mwifiex/sdio.c: mmc_hw_reset(func->card->host); drivers/net/wireless/rsi/rsi_91x_sdio.c: err = mmc_wait_for_cmd(host, &cmd, 3); ...anyway, I'll give it a few days and if nobody else chimes in then I'll assume you indeed want "sdio_" wrappers for things and I'll post a v4. If patch #1 happens to land in the meantime then I won't object. ;-) -Doug