From: Doug Anderson <dianders@google.com>
To: yangcong <yangcong5@huaqin.corp-partner.google.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v2 2/2] dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
Date: Fri, 20 Aug 2021 08:45:29 -0700 [thread overview]
Message-ID: <CAD=FV=UAD1dM9EqGDr1zLDUmrLMPxmAp7-da+ifqXvDcRbpqdQ@mail.gmail.com> (raw)
In-Reply-To: <20210820070113.45191-3-yangcong5@huaqin.corp-partner.google.com>
Hi,
On Fri, Aug 20, 2021 at 12:01 AM yangcong
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> The auo,b101uan08.3 panel (already supported by this driver) has
> a 3.3V rail that needs to be turned on. For previous users of
> this panel this voltage was directly output by pmic. On a new
> user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
> to turn the 3.3V rail on.
>
> Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
> ---
> .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 3 +++
> 1 file changed, 3 insertions(+)
However you're sending your patches is really confusing my email
client. I think part of the problem is that you sent "v2" as
"In-Reply-To" your "v1". You shouldn't do that. You also seem to be
sending duplicates. :(
Might I suggest using "patman" to simplify things for you?
https://source.denx.de/u-boot/u-boot/blob/master/tools/patman/README
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> index 38bc1d1b511e..a7091ae0f791 100644
> --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> @@ -36,6 +36,9 @@ properties:
> pp1800-supply:
> description: core voltage supply
>
> + pp3300-supply:
> + description: core voltage supply
This would probably be slightly better if it said "3.3 V supply"
instead of "core voltage supply", but it doesn't matter a ton to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2021-08-20 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 12:48 [v1 0/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail yangcong
2021-08-19 12:48 ` [v1 1/2] " yangcong
2021-08-19 12:48 ` [v1 2/2] dt-bindings: " yangcong
2021-08-19 21:19 ` Rob Herring
2021-08-20 6:33 ` [v2 0/2] " yangcong
2021-08-20 6:33 ` [v2 1/2] " yangcong
2021-08-20 6:33 ` [v2 2/2] dt-bindings: " yangcong
2021-08-20 7:01 ` [v2 0/2] " yangcong
2021-08-20 7:01 ` [v2 1/2] " yangcong
2021-08-20 15:46 ` Doug Anderson
2021-08-20 7:01 ` [v2 2/2] dt-bindings: " yangcong
2021-08-20 15:45 ` Doug Anderson [this message]
2021-08-24 14:42 ` Rob Herring
2021-08-26 19:48 ` [v2 0/2] " Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UAD1dM9EqGDr1zLDUmrLMPxmAp7-da+ifqXvDcRbpqdQ@mail.gmail.com' \
--to=dianders@google.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).