From: Doug Anderson <dianders@chromium.org>
To: Rob Herring <robh@kernel.org>
Cc: Cong Yang <yangcong5@huaqin.corp-partner.google.com>,
sam@ravnborg.org, neil.armstrong@linaro.org, daniel@ffwll.ch,
linus.walleij@linaro.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, airlied@gmail.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
xuxinxiong@huaqin.corp-partner.google.com
Subject: Re: [PATCH v2 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings
Date: Mon, 22 Apr 2024 14:15:36 -0700 [thread overview]
Message-ID: <CAD=FV=UCq9FmhFHfczxGAM+P=foz-XmNvO9r79=3=0SXUYQz8Q@mail.gmail.com> (raw)
In-Reply-To: <20240422151424.GA1273350-robh@kernel.org>
Hi,
On Mon, Apr 22, 2024 at 8:14 AM Rob Herring <robh@kernel.org> wrote:
>
> > +additionalProperties: false
>
> Perhaps 'unevaluatedProperties' instead. Don't you want to support
> standard properties such as width-mm/height-mm?
For at least those two properties, it looks like the answer is "no".
From reading the Linux driver it appears that physical width/height is
implied by the compatible string. Unless there are other properties we
think we need, maybe it's fine to keep "additionalProperties" ?
-Doug
next prev parent reply other threads:[~2024-04-22 21:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 9:03 [PATCH v2 0/7] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel Cong Yang
2024-04-22 9:03 ` [PATCH v2 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings Cong Yang
2024-04-22 15:14 ` Rob Herring
2024-04-22 21:15 ` Doug Anderson [this message]
2024-04-22 9:03 ` [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver Cong Yang
2024-04-22 21:17 ` Doug Anderson
2024-04-23 9:37 ` cong yang
2024-04-23 16:19 ` Doug Anderson
2024-04-24 2:42 ` cong yang
2024-04-24 22:43 ` Doug Anderson
2024-04-22 9:03 ` [PATCH v2 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel Cong Yang
2024-04-22 21:17 ` Doug Anderson
2024-04-22 9:03 ` [PATCH v2 4/7] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60 Cong Yang
2024-04-22 15:16 ` Rob Herring
2024-04-24 2:28 ` cong yang
2024-04-22 9:03 ` [PATCH v2 5/7] drm/panel: himax-hx83102: Support for BOE nv110wum-l60 MIPI-DSI panel Cong Yang
2024-04-22 9:03 ` [PATCH v2 6/7] dt-bindings: display: panel: Add compatible for IVO t109nw41 Cong Yang
2024-04-22 9:03 ` [PATCH v2 7/7] drm/panel: himax-hx83102: Support for IVO t109nw41 MIPI-DSI panel Cong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UCq9FmhFHfczxGAM+P=foz-XmNvO9r79=3=0SXUYQz8Q@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=xuxinxiong@huaqin.corp-partner.google.com \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).