From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9243C2D0C9 for ; Thu, 12 Dec 2019 16:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E2A921655 for ; Thu, 12 Dec 2019 16:09:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fWA8oi4B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729845AbfLLQJY (ORCPT ); Thu, 12 Dec 2019 11:09:24 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:37072 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729605AbfLLQJY (ORCPT ); Thu, 12 Dec 2019 11:09:24 -0500 Received: by mail-io1-f68.google.com with SMTP id k24so3366927ioc.4 for ; Thu, 12 Dec 2019 08:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZSuulaHZP7wrCDMhvr1mBj+rW2++SNmugkVI+athuy0=; b=fWA8oi4BNyT1AqiAexpCYnMadFV+cK60+9u4U1OnYTHAl/RMEBEZ1qUyJVXYWlq3AK 1leJZGQkxQSsY3/UJ2F5h18b+SaKi1Ry6fQ3COI85Vg+fxU9oDxBY1qGfUS0JTTufQJq 47xWja5YZkpXtzKA6w1TMeZbU4DNqk5ccNV54= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZSuulaHZP7wrCDMhvr1mBj+rW2++SNmugkVI+athuy0=; b=bkfj4pxGObAyDz1MAMdJGM7p4YIXvl1CcHPqxgMYbjlROA1YweqaudyVf1obf3gWB6 F8XoZThn4tn5RuAu+BgQ8/uMoOZ94umzzbmKoSsev2BmUd0Kkop4jtNDnyOozxDGqMLZ 8oLJtvogiALFZr40KDjRQkXDWTzMp74i6grvgYsLLcCr7zp0VvwsSpQLU0DvOjMjKGZu uf3tVg5zwzHXWJU5KOZM5G0UWv/ZxEgdgzYFoEkANakzBK7EmqDK5ibdQSxeKlTMTBsw x2COGkg6ZJtQcpFyKLqi7VDGzYyQt8cVs8CnaIJt7cgSWyW10xJinqW1dOmB0l79/5MK KkfA== X-Gm-Message-State: APjAAAVIPCLm16k2YXExTJeUNx5Z/BFnWI08dGQ0RF3fkhfQISFUefTM BAwAH0V/rB74J6bSPMc6yDtIHo1w/sM= X-Google-Smtp-Source: APXvYqwoqPb9/HG+WP4rKEz37Ib9WwlFp/wrMrMvTRf7m+MPkPOnkWhTzw89izdETFGcfHFWFNfyRg== X-Received: by 2002:a05:6602:1c6:: with SMTP id w6mr3543011iot.44.1576166962955; Thu, 12 Dec 2019 08:09:22 -0800 (PST) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com. [209.85.166.48]) by smtp.gmail.com with ESMTPSA id n5sm1813389ila.7.2019.12.12.08.09.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2019 08:09:21 -0800 (PST) Received: by mail-io1-f48.google.com with SMTP id k24so3366776ioc.4 for ; Thu, 12 Dec 2019 08:09:21 -0800 (PST) X-Received: by 2002:a02:2385:: with SMTP id u127mr8799499jau.127.1576166960582; Thu, 12 Dec 2019 08:09:20 -0800 (PST) MIME-Version: 1.0 References: <1574934847-30372-1-git-send-email-rkambl@codeaurora.org> <1574934847-30372-2-git-send-email-rkambl@codeaurora.org> In-Reply-To: From: Doug Anderson Date: Thu, 12 Dec 2019 08:09:08 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: sc7180: Add device node support for TSENS in SC7180 To: Amit Kucheria Cc: Rajeshwari , Andy Gross , Bjorn Andersson , Rob Herring , Mark Rutland , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , sivaa@codeaurora.org, sanm@codeaurora.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Dec 12, 2019 at 3:00 AM Amit Kucheria wrote: > > Hi Rajeshwari, > > On Thu, Nov 28, 2019 at 3:25 PM Rajeshwari wrote: > > > > Add TSENS node and user thermal zone for TSENS sensors in SC7180. > > > > Signed-off-by: Rajeshwari > > --- > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 527 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 527 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 666e9b9..6656ffc 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -911,6 +911,26 @@ > > status = "disabled"; > > }; > > > > + tsens0: thermal-sensor@c263000 { > > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > > + reg = <0 0x0c263000 0 0x1ff>, /* TM */ > > + <0 0x0c222000 0 0x1ff>; /* SROT */ > > + #qcom,sensors = <15>; > > + interrupts = ; > > + interrupt-names = "uplow"; > > + #thermal-sensor-cells = <1>; > > + }; > > + > > + tsens1: thermal-sensor@c265000 { > > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > > + reg = <0 0x0c265000 0 0x1ff>, /* TM */ > > + <0 0x0c223000 0 0x1ff>; /* SROT */ > > + #qcom,sensors = <10>; > > + interrupts = ; > > + interrupt-names = "uplow"; > > + #thermal-sensor-cells = <1>; > > + }; > > + > > spmi_bus: spmi@c440000 { > > compatible = "qcom,spmi-pmic-arb"; > > reg = <0 0x0c440000 0 0x1100>, > > @@ -1121,6 +1141,513 @@ > > }; > > }; > > > > + thermal-zones { > > + cpu0-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 1>; > > + > > + trips { > > + cpu0_alert0: trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + cpu0_alert1: trip-point1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + cpu0_crit: cpu_crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > Where are the cooling maps for all the cpu thermal zones? A passive > trip point w/o a cooling map is not of much use. If you are waiting > for cpufreq support to land before adding them, then remove the > passive trip points for now and add them along with the cooling maps > when you have cooling devices. I will note that cpufreq support has landed in the qcom tree:: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=86899d8235ea0d3d7c293404fb43a6fabff866e6 ...so I guess the right thing is to send a patch adding the cooling maps for the cpu thermal zones? -Doug