From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA695C433EF for ; Tue, 3 May 2022 15:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238846AbiECPuO (ORCPT ); Tue, 3 May 2022 11:50:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238590AbiECPuL (ORCPT ); Tue, 3 May 2022 11:50:11 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D035D33E3F for ; Tue, 3 May 2022 08:46:38 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id i20so17723208ion.0 for ; Tue, 03 May 2022 08:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DmEYqT+9Ka7njk/TwR9G+Gdm+tqkABc7dcTcU/7kYZY=; b=IPLzFJvRDQ9r0mh8TcbmuNu1p2ZCdA+ba9sSjOT1tZkhVfsHcEFr2+YTCL1iNWL6fI 2UmCRjoVIb5YpVcAKV+QVUbX4nNZeBM0yzyPY5NKn8pVRSa1OAvQJTqAPGL6I1tR9/7p o7JiIwX99eJ9jk7iN47UV8C2OJuigQEUnteBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DmEYqT+9Ka7njk/TwR9G+Gdm+tqkABc7dcTcU/7kYZY=; b=MEh/qBETGJzfiV1GRB5WYkI+HPAEG168z0Dk9Xc99uNy9qF5jEKZ+Ivtz/RbjwKOeQ hiTd7UjHxmLBqQWdUsEvmy+dwxN7JnmSTtHsHriZbR3bzBsWxp9t5WneSQHWavw9ukOj LSBnn+SZRHMqWuxfSBaZH7rcpt98CgfBZ1HwaKLKccB5cj9Vns3WYIWmssvQfreMRQaX SWrFKWoS5TI/SFEm5Eig0UxDlSimIo8HGCb6zVpcwJI3igmFocustTETppusLyQLP6p9 v+QlbV8odW7ViR3TrySJX99R94cYGVU7ogB6zKauOFVE0g6FwC0ynWLq8fO8r2bXLRet /nIA== X-Gm-Message-State: AOAM531cEhqygg3cyqvsMS359snCnq67L6ceAKsYHIaZtrjJD63/y/l0 oT5Ajn191ArJsDVb4WvkH30MQ3AMU39WPI5O X-Google-Smtp-Source: ABdhPJwSDqDu5gzPwUtOvp2vuC/0m4i8s8GWFgbnz85lVn+i40s1HuWWpeld2lxRffCVlUKMPO2/yw== X-Received: by 2002:a5e:d61a:0:b0:657:c106:6009 with SMTP id w26-20020a5ed61a000000b00657c1066009mr6151036iom.105.1651592798179; Tue, 03 May 2022 08:46:38 -0700 (PDT) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com. [209.85.166.182]) by smtp.gmail.com with ESMTPSA id t14-20020a92c90e000000b002cde6e35305sm3304581ilp.79.2022.05.03.08.46.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 08:46:36 -0700 (PDT) Received: by mail-il1-f182.google.com with SMTP id h11so5366610ila.5 for ; Tue, 03 May 2022 08:46:36 -0700 (PDT) X-Received: by 2002:a92:c263:0:b0:2cf:c0e:bd81 with SMTP id h3-20020a92c263000000b002cf0c0ebd81mr4741427ild.220.1651592796090; Tue, 03 May 2022 08:46:36 -0700 (PDT) MIME-Version: 1.0 References: <20220503042242.3597561-1-swboyd@chromium.org> <20220503042242.3597561-2-swboyd@chromium.org> <2280875f-fbd8-0dfd-5a0a-1d7fceb856e4@linaro.org> In-Reply-To: <2280875f-fbd8-0dfd-5a0a-1d7fceb856e4@linaro.org> From: Doug Anderson Date: Tue, 3 May 2022 08:46:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible To: Krzysztof Kozlowski Cc: Stephen Boyd , Dmitry Torokhov , LKML , patches@lists.linux.dev, chrome-platform@lists.linux.dev, Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Benson Leung , Guenter Roeck , Hsin-Yi Wang , "Joseph S. Barrera III" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, May 3, 2022 at 8:42 AM Krzysztof Kozlowski wrote: > > On 03/05/2022 06:22, Stephen Boyd wrote: > > If the ChromeOS board is a detachable, this cros-ec-keyb device won't > > have a matrix keyboard but it may have some button switches, e.g. volume > > buttons and power buttons. The driver still registers a keyboard though > > and that leads to userspace confusion around where the keyboard is. > > (...) > > > > > +if: > > + properties: > > + compatible: > > + contains: > > + const: google,cros-ec-keyb > > +then: > > + allOf: > > + - $ref: "/schemas/input/matrix-keymap.yaml#" > > + required: > > + - keypad,num-rows > > + - keypad,num-columns > > + - linux,keymap > > else: > properties: > function-row-phsymap: false > google,needs-ghost-filter: false > > Because these are not valid for the non-matrix-keyboard case, right? Isn't that implicit because this file has `unevaluatedProperties: false` ? -Doug