From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 334F4C433F5 for ; Thu, 11 Nov 2021 23:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A8156124C for ; Thu, 11 Nov 2021 23:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234543AbhKKX6f (ORCPT ); Thu, 11 Nov 2021 18:58:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234495AbhKKX6e (ORCPT ); Thu, 11 Nov 2021 18:58:34 -0500 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6672DC061766 for ; Thu, 11 Nov 2021 15:55:44 -0800 (PST) Received: by mail-io1-xd32.google.com with SMTP id v65so9066444ioe.5 for ; Thu, 11 Nov 2021 15:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0JJWVJalP8CdFuuTjj01mh7dvetDFFkhbScBxvOmImE=; b=eSPxiY6MEyQX62rXAkb0w5NNZxOWa7d9ff+SnhlWhS0oTPRJBa2CcaipLWPc0J0gKP l053mItULP8bYA7RJDTqKIuh/aUAXRYJq7/ITIAGvRYRnTF+9kbGLe7DBD/rhP/0a1Em gAQFu3Lzm+26xVXYz2R/xCLPJIf1sko7Ns7Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0JJWVJalP8CdFuuTjj01mh7dvetDFFkhbScBxvOmImE=; b=qYMUcbiyXPmuqoqdCUAJCun5mSKvZMkWdwiZ3GeoNmIVuhMTq7rT9G2DSnpotk5BNs 0QUahgdFctIVrXgWNjfNeLRm+2HJ8f9LC2xh6QkDuBMo72uXNBXqvJac30wa4I8htnC4 N45w0iY53wcOBLuQJuhnf4Kx9/UQ+0Jd2/YdXyATIFP6QswnYEwqPBbufns6Cum50Hoa sWzX7DLmhG2Ltxphd8PHplURCecxDoIm/c2i9ue/1526OygFObi00KKiZAL4KIFyNWdX vUkZV0RMP/wsXokzByBRPkrRhE+YFg18NPac/r9p8uOcglmF98qLUVp9cprqrlDpRcir UWLw== X-Gm-Message-State: AOAM533lZuRprJc2hTly8lbe3x+yTIgiJOvE6gHw7pX9gAEBMVNNQAOd H7DA+vK+dc+wnxXYMjLWXzLyxLShuNH38w== X-Google-Smtp-Source: ABdhPJwrEU6qtA+8qrESFEzKvwJhC6il4eUNeE2Q9jkjrwzMmPHaluBt9ZTo0cx6Jr2SvrCQWkOtwg== X-Received: by 2002:a5d:8451:: with SMTP id w17mr7657132ior.139.1636674943778; Thu, 11 Nov 2021 15:55:43 -0800 (PST) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com. [209.85.166.174]) by smtp.gmail.com with ESMTPSA id 15sm2713589ilq.4.2021.11.11.15.55.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 15:55:43 -0800 (PST) Received: by mail-il1-f174.google.com with SMTP id h23so7403983ila.4 for ; Thu, 11 Nov 2021 15:55:43 -0800 (PST) X-Received: by 2002:a05:6e02:1a67:: with SMTP id w7mr6255484ilv.165.1636674497968; Thu, 11 Nov 2021 15:48:17 -0800 (PST) MIME-Version: 1.0 References: <20210813195228.2003500-1-mka@chromium.org> <20210813125146.v16.5.If248f05613bbb06a44eb0b0909be5d97218f417b@changeid> In-Reply-To: <20210813125146.v16.5.If248f05613bbb06a44eb0b0909be5d97218f417b@changeid> From: Doug Anderson Date: Thu, 11 Nov 2021 15:48:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v16 5/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' To: Matthias Kaehlcke Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , devicetree@vger.kernel.org, Peter Chen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bastien Nocera , Ravi Chandra Sadineni , Michal Simek , Roger Quadros , Krzysztof Kozlowski , Stephen Boyd , Andrew Lunn , Aswath Govindraju , Dmitry Osipenko , Fabio Estevam , Gregory Clement , Krzysztof Kozlowski , Pawel Laszczak , Sebastian Hesselbarth , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Aug 13, 2021 at 12:52 PM Matthias Kaehlcke wrote: > > config USB_DWC3 > tristate "DesignWare USB3 DRD Core Support" > - depends on (USB || USB_GADGET) && HAS_DMA > - select USB_XHCI_PLATFORM if USB_XHCI_HCD > + depends on ((USB && USB_XHCI_PLATFORM) || USB_GADGET) && HAS_DMA Technically you don't need the "USB &&", right? Since USB_XHCI_PLATFORM is defined in 'usb/host/Kconfig' and that's only even included if USB is defined. So it can be just: depends on (USB_XHCI_PLATFORM || USB_GADGET) && HAS_DMA That's not terribly important, though, so: Reviewed-by: Douglas Anderson