From: Doug Anderson <dianders@chromium.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Rajendra Nayak <rnayak@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: sc7180: Add clock controller nodes
Date: Mon, 27 Jan 2020 15:11:33 -0800 [thread overview]
Message-ID: <CAD=FV=UGSN8YRtbEsbHOF6DRvi5=hUTeV+Aam4QKKVL99L4uBA@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=X4gW3cpFPTL7KmocP1z7fK1fSRjg7BYjA7D_Uu7p5gnQ@mail.gmail.com>
Hi,
On Wed, Jan 22, 2020 at 4:46 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Dec 27, 2019 at 12:38 AM Taniya Das <tdas@codeaurora.org> wrote:
> >
> > Add the display, video & graphics clock controller nodes supported on
> > SC7180.
> >
> > Signed-off-by: Taniya Das <tdas@codeaurora.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180.dtsi | 33 +++++++++++++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
>
> Can you add these to your patch?
>
> #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
> #include <dt-bindings/clock/qcom,gpucc-sc7180.h>
>
> ...otherwise the first user of each of the clocks will need to add the
> #include and depending on what order patches landed things can get
> weird. I think it's cleaner to assume that there will soon be a user
> and proactively add the #includes.
>
> NOTE: at least one user of your patch can be found at
> <https://lore.kernel.org/r/1579621928-18619-1-git-send-email-harigovi@codeaurora.org>.
> They don't add the #includes which means they don't compile atop your
> patch.
Breadcrumbs that I addressed my own feedback because I wanted to
include Taniya's patch atop my series. See:
https://lore.kernel.org/r/20200124144154.v2.10.I1a4b93fb005791e29a9dcf288fc8bd459a555a59@changeid
-Doug
prev parent reply other threads:[~2020-01-27 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 8:37 [PATCH] arm64: dts: sc7180: Add clock controller nodes Taniya Das
2020-01-23 0:46 ` Doug Anderson
2020-01-27 23:11 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UGSN8YRtbEsbHOF6DRvi5=hUTeV+Aam4QKKVL99L4uBA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).