From: Doug Anderson <firstname.lastname@example.org> To: Dilip Kota <email@example.com> Cc: Stephen Boyd <firstname.lastname@example.org>, Mark Brown <email@example.com>, Matthias Kaehlcke <firstname.lastname@example.org>, LKML <email@example.com>, linux-spi <firstname.lastname@example.org>, linux-arm-msm <email@example.com>, Girish Mahadevan <firstname.lastname@example.org>, Andy Gross <email@example.com> Subject: Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP Date: Tue, 18 Sep 2018 13:12:04 -0700 [thread overview] Message-ID: <CAD=FV=UJo0yL-MiQyJrS85p-RFs3TqWdagVpjCdtZfEkgYCYbg@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi, On Tue, Sep 18, 2018 at 11:09 AM Dilip Kota <email@example.com> wrote: > > From: Girish Mahadevan <firstname.lastname@example.org> > > This driver supports GENI based SPI Controller in the Qualcomm SOCs. The > Qualcomm Generic Interface (GENI) is a programmable module supporting a > wide range of serial interfaces including SPI. This driver supports SPI > operations using FIFO mode of transfer. > > Signed-off-by: Girish Mahadevan <email@example.com> > Signed-off-by: Dilip Kota <firstname.lastname@example.org> > --- > Addressing all the reviewer commets given in Patchset1. > Summerizing the chages below: > > Move prepare_transfer_hardware to probe > Fix the unbind failure > Add Spinlock > Use readl/writel() instead of _relaxed() > Remove __func__ in dev_err > Declare register variables as u32 > Don't initialize variables and then overwrite them > Remove unused step > Remove IRQ entry in geni struct > Remove extra paranthesis > Reframe probe errors > Change the tx_fifo_width naming in handle_rx and handle_tx > Declare spi_geni_master as 'mas' in complete driver. > Correcting the punctuation in the comments. > Adding comments in the code while setting Tx WaterMark Register. > get_spi_clk_cfg() fixes > Rewrite the geni_spi_handle_tx() and geni_spi_handle_rx() > > Regarding the suspend/resume and loopback failures, i am working to update in next patch series > drivers/spi/Kconfig | 12 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-geni-qcom.c | 653 ++++++++++++++++++++++++++++++++++++++ > include/linux/spi/spi-geni-qcom.h | 14 + > 4 files changed, 680 insertions(+) I've confirmed that all the feedback I'm aware of from previous versions of this patch has now been addressed, except as noted above: * suspend callback still looks a little wonky. * loopback doesn't actually work IMO it would be OK to land this patch and address the suspend callback / loopback issues in later patches, but obviously that's for Mark to decide. NOTE: for this patch to land it must be based on a tree that includes the patch ("soc: qcom: geni: Make version macros simpler")  in order to compile. It would also be nice if it was also based upon the patches ("soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()")  and ("soc: qcom: geni: geni_se_clk_freq_match() should always accept multiples") . Those aren't needed for things to compile but are technically needed for correctness. +Andy Gross has said he'll put that the above 3 patches in his tree in a way that it would be easy to pull in Mark: it would be super if you had a chance to take a look at this patch now and see what you think.  https://email@example.com  https://firstname.lastname@example.org  https://email@example.com With all that said, I'm happy adding: Reviewed-by: Douglas Anderson <firstname.lastname@example.org> Tested-by: Douglas Anderson <email@example.com> -Doug
next prev parent reply other threads:[~2018-09-18 20:12 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-18 18:07 [PATCH V4 0/4] spi-geni-qcom: QUP SPI GENI driver and SPI device tree bindings Dilip Kota 2018-09-18 18:07 ` [PATCH V4 1/4] dt-bindings: soc: qcom: Remove SPI controller maximum frequency binding Dilip Kota 2018-09-18 20:11 ` Doug Anderson 2018-09-20 15:38 ` Stephen Boyd 2018-09-26 22:51 ` Rob Herring 2018-09-18 18:07 ` [PATCH V4 2/4] dt-bindings: soc: qcom: GENI SE SPI controller device tree binding Dilip Kota 2018-09-18 20:11 ` Doug Anderson 2018-09-20 15:39 ` Stephen Boyd 2018-09-26 22:51 ` Rob Herring 2018-09-18 18:07 ` [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP Dilip Kota 2018-09-18 20:12 ` Doug Anderson [this message] 2018-09-19 0:41 ` kbuild test robot 2018-09-24 16:47 ` Stephen Boyd 2018-09-25 19:36 ` dkota 2018-09-25 19:54 ` Doug Anderson 2018-09-26 18:36 ` dkota 2018-09-18 18:07 ` [PATCH V4 4/4] spi: spi-geni-qcom: Plugin API to assert and de-assert Chipselect Dilip Kota 2018-09-18 20:12 ` Doug Anderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAD=FV=UJo0yL-MiQyJrS85p-RFs3TqWdagVpjCdtZfEkgYCYbg@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).