From: Doug Anderson <dianders@chromium.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Julius Werner <jwerner@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pstore/ram: Improve backward compatibility with older Chromebooks
Date: Tue, 7 May 2019 09:25:32 -0700 [thread overview]
Message-ID: <CAD=FV=UKTDFwq3PSdpPmShRcOtZaH1mU=2H-ynoG4VooV=rKVQ@mail.gmail.com> (raw)
In-Reply-To: <CA+ASDXOkHxYumCBv-T0gxTjdMVTu-c=33Lk-0TUgJ3WGUn2DVQ@mail.gmail.com>
Hi,
On Mon, May 6, 2019 at 2:40 PM Brian Norris <briannorris@chromium.org> wrote:
>
> On Fri, May 3, 2019 at 10:48 AM Douglas Anderson <dianders@chromium.org> wrote:
> > When you try to run an upstream kernel on an old ARM-based Chromebook
> > you'll find that console-ramoops doesn't work.
>
> Ooh, nice! I still get annoyed by old depthcharge firmware. It's
> almost as if we should have gotten an upstream binding approved before
> baking it into firmware...
>
> > --- a/fs/pstore/ram.c
> > +++ b/fs/pstore/ram.c
>
> > @@ -703,6 +704,23 @@ static int ramoops_parse_dt(struct platform_device *pdev,
> >
> > #undef parse_size
> >
> > + /*
> > + * Some old Chromebooks relied on the kernel setting the console_size
> > + * and pmsg_size to the record size since that's what the downstream
> > + * kernel did. These same Chromebooks had "ramoops" straight under
> > + * the root node which isn't according to the upstream bindings.
>
> The last part of the sentence technically isn't true -- the original
> bindings (notably, with no DT maintainer Reviewed-by) didn't specify
> where such a node should be found:
>
> 35da60941e44 pstore/ram: add Device Tree bindings
>
> so child-of-root used to be a valid location. But anyway, this code is
> just part of a heuristic for "old DT" (where later bindings clarified
> this), so it still seems valid.
I agree that it was unclear in the past, but it is true that being
under the root node is not according to the _current_ upstream
bindings, right? ;-)
> > Let's
> > + * make those old Chromebooks work by detecting this and mimicing the
>
> s/mimicing/mimicking/
Kees: if you want me to spin with this typo fix then please let me
know. Otherwise I'll assume it's less work for you to just fix it
yourself when applying.
-Doug
next prev parent reply other threads:[~2019-05-07 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 17:47 [PATCH] pstore/ram: Improve backward compatibility with older Chromebooks Douglas Anderson
2019-05-03 19:06 ` Guenter Roeck
2019-05-06 21:09 ` Kees Cook
2019-05-06 21:33 ` Rob Herring
2019-05-06 23:58 ` Doug Anderson
2019-05-07 4:51 ` Doug Anderson
2019-05-07 22:17 ` Frank Rowand
2019-05-07 22:19 ` Doug Anderson
2019-05-07 22:23 ` Frank Rowand
2019-05-06 21:40 ` Brian Norris
2019-05-07 16:25 ` Doug Anderson [this message]
2019-05-07 16:48 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UKTDFwq3PSdpPmShRcOtZaH1mU=2H-ynoG4VooV=rKVQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=anton@enomsg.org \
--cc=briannorris@chromium.org \
--cc=ccross@android.com \
--cc=groeck@chromium.org \
--cc=jwerner@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).