Re: [PATCH 5/7] regulator: core: add enable_count for consumers to debug fs

From: Doug Anderson <dianders@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Evan Green <evgreen@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Dmitry Osipenko <digetx@gmail.com>,
	ryandcase@chromium.org, David Collins <collinsd@codeaurora.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] regulator: core: add enable_count for consumers to debug fs
Date: Tue, 20 Nov 2018 08:52:14 -0800	[thread overview]
Message-ID: <CAD=FV=UO1Dt3SeDs22EgH-95dWX+jq0sU7zzRgew11_DVw43cg@mail.gmail.com> (raw)
In-Reply-To: <20181120161055.GI3894@sirena.org.uk>

Hi,

On Tue, Nov 20, 2018 at 8:10 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Nov 19, 2018 at 04:26:52PM -0800, Douglas Anderson wrote:
> > Now that consumers all keep track of their own enable count, let's add
> > it into the regulator_summary.
>
> This patch series contains a bunch of random stuff that's not
> particularly related to each other or even dependent on each other -
> it's better to just send unrelated things in unrelated threads, it
> makes it clear what actual dependencies exist, makes the serieses that
> are sent easier to understand and stops things getting blocked on
> unrelated changes earlier in the series.

Sure.  You want me to repost things now or wait until you've had a
chance to look things over?

Certainly patch #1 is totally self-contained.
  regulator: core: Properly expose requested_microamps in sysfs

Patch #2 is self-contained but helps with confirming patches later in
the series:
  regulator: core: Don't assume always_on when is_enabled returns err

Patch #3: self-contained but helps with confirming patches later in the series:
  regulator: core: Don't double-disable supplies in regulator_disable_deferred()

Patches #4 and #5 are intimately tied.  As per discussion, I'll squash
together for v2.
  regulator: core: Only count load for enabled consumers
  regulator: core: add enable_count for consumers to debug fs

Patch #6: wasn't originally self-contained when I wrote it 2 days ago,
but after commit f8702f9e4aa7 ("regulator: core: Use ww_mutex for
regulators locking") it is.
  regulator: core: Avoid propagating to supplies when possible

Patch #7: Now that I know you want to loop over use_count, depends on
patch #6 which changes how many times supplies are enabled.
   regulator: core: Remove loop disabling supplies in regulator_force_disable()

I don't want to send v2 of things while you're still reviewing.  If
you have a chance give me a ping when you're ready for me to send out
v2 of things.  ...otherwise I'll plan to send it out later today or
tomorrow morning.

-Doug