From: Doug Anderson <dianders@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] arm64: dts: qcom: sdm845: Increase address and size cells for soc
Date: Thu, 17 Jan 2019 09:47:16 -0800 [thread overview]
Message-ID: <CAD=FV=UPwHux1nBm_eO3Uida6hSZLrOwdMpjMQQb5daa3USpqg@mail.gmail.com> (raw)
In-Reply-To: <20190117042940.25487-2-bjorn.andersson@linaro.org>
Hi,
On Wed, Jan 16, 2019 at 8:30 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> The busses on SDM845 provides 36 address bits, extend the address and
> size cells to make it possible to describe this in "ranges" and
> "dma-ranges".
>
> While touching all reg properties, addresses are padded to 8 digits.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v3:
> - Split out address-cells/size-cells change
> - Rewrote commit message from scratch
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 300 +++++++++++++--------------
> 1 file changed, 150 insertions(+), 150 deletions(-)
It was "fun" trying to apply this patch since you now based it on
Andy's for-next branch plus outstanding patches. I suppose that's my
fault for suggesting that, but maybe next time it would be helpful if
you could publish a branch somewhere that provided your basis?
NOTE: my tree also has "qcom,sdm845-lpasscc" so I had to manually fix
that last address too. I believe you left this out of your tree
because it was causing you trouble on MTP. That's fine and upstream
can fix it up when it lands.
In general everything here looks good though and I'd suggest landing
it (and the patches it depends on) ASAP because otherwise we'll keep
fighting conflicts.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2019-01-17 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 4:29 [PATCH v4 0/2] arm64: dts: qcom: sdm845: Fix DMA allocations for devices with IOMMU Bjorn Andersson
2019-01-17 4:29 ` [PATCH v4 1/2] arm64: dts: qcom: sdm845: Increase address and size cells for soc Bjorn Andersson
2019-01-17 17:47 ` Doug Anderson [this message]
2019-01-17 18:05 ` Stephen Boyd
2019-01-17 4:29 ` [PATCH v4 2/2] arm64: dts: qcom: sdm845: Extend ranges and describe DMA space Bjorn Andersson
2019-01-17 17:47 ` Doug Anderson
2019-01-17 18:22 ` Stephen Boyd
2019-01-18 13:05 ` [PATCH v4 0/2] arm64: dts: qcom: sdm845: Fix DMA allocations for devices with IOMMU Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UPwHux1nBm_eO3Uida6hSZLrOwdMpjMQQb5daa3USpqg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).