From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD60C4332E for ; Tue, 2 Mar 2021 07:32:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DED5760240 for ; Tue, 2 Mar 2021 07:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1575463AbhCBD4S (ORCPT ); Mon, 1 Mar 2021 22:56:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344190AbhCAWvC (ORCPT ); Mon, 1 Mar 2021 17:51:02 -0500 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EF30C06178C for ; Mon, 1 Mar 2021 14:43:32 -0800 (PST) Received: by mail-qk1-x733.google.com with SMTP id h8so18427227qkk.6 for ; Mon, 01 Mar 2021 14:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KSW03qXRNzDDWUFd7HDVgAkqmhLV+uIrk9Nn7LdcJQA=; b=drUkO2+KLPEIvI8tMqJjJb9nI3O6lfZOPMqiw32jogITD6yPK2lJ6CRWJyZu2FXq6D eGwQ6llMSy51834BWN+9xSe51F+x0CDiVHP4JgyeIr/DPQEYs0HHYbKvFJwy5nSkT+7o MQmTVUeL6YlzNqkHelJVuAyZ2HtwPyNVBmQdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KSW03qXRNzDDWUFd7HDVgAkqmhLV+uIrk9Nn7LdcJQA=; b=h92zSiVSZWE+2aAtovk+VTgHYJ1JoDWr2QWKFUHlPs0qEj8VvO9N2XbyhxYNRYw0eb HWJa3qhRg0vST6LlcEr0hKcj5iX/OCst95RUfI6bFvAIuOrSa13tL/P6hNdy1cV4js4S 2ecNQhbFI0e8/DRR6LIzF6w2sD9FqKcBnfrqERsfNHe31ypjr6bZjvTw6vH+Fy/uti3K C+8CftMqJKKVrNob2RCn+BLXmCdXFLSFBlH4YDQwlPcTGwD75nQtH6lr8FEy+hOg5upR 6+B25UNFPCkWaH+qwdWWqwFIU+uZMxiqIwIyMLumUKXQNg4jPPbJ6lWbTMp3T2PlNYi7 fquQ== X-Gm-Message-State: AOAM531OAYPnBYixsbMBdH+R7nfTMQbQf+hChLQYCtdK02fBvgCDWmaJ Oly/HAK7IypJyXynE7RM31l5FAJ8JyasSg== X-Google-Smtp-Source: ABdhPJwhG4Bq5Zq4WvLFoOh/YKmbpO5bNfre+hgz6DBleEYW4nrqH/EbLJpRsfAR/4tJ1q7J/DtKfw== X-Received: by 2002:a37:9444:: with SMTP id w65mr16813280qkd.88.1614638610856; Mon, 01 Mar 2021 14:43:30 -0800 (PST) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id d14sm3607814qkg.33.2021.03.01.14.43.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 14:43:30 -0800 (PST) Received: by mail-yb1-f170.google.com with SMTP id p186so18679498ybg.2 for ; Mon, 01 Mar 2021 14:43:29 -0800 (PST) X-Received: by 2002:a5b:84f:: with SMTP id v15mr24920639ybq.79.1614638609454; Mon, 01 Mar 2021 14:43:29 -0800 (PST) MIME-Version: 1.0 References: <523a5af43615b804aa1211a3f27e06226d7159bc.1614624041.git.saiprakash.ranjan@codeaurora.org> In-Reply-To: <523a5af43615b804aa1211a3f27e06226d7159bc.1614624041.git.saiprakash.ranjan@codeaurora.org> From: Doug Anderson Date: Mon, 1 Mar 2021 14:43:18 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 2/4] perf evsel: Print warning for excluding kernel mode instruction tracing To: Sai Prakash Ranjan Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Leo Yan , Jiri Olsa , Namhyung Kim , coresight@lists.linaro.org, Stephen Boyd , Denis Nikitin , Mattias Nissler , Al Grant , linux-arm-msm , LKML , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: > > Add a warning message to check CONFIG_EXCLUDE_KERNEL_HW_ITRACE kernel > config which excludes kernel mode instruction tracing to help perf tool > users identify the perf event open failure when they attempt kernel mode > tracing with this config enabled. > > Tested-by: Denis Nikitin > Signed-off-by: Sai Prakash Ranjan > --- > tools/perf/util/evsel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I'm not really knowledgeable at all about the perf subsystem so my review doesn't hold a lot of weight. However, Sai's patch seems sane to me. Reviewed-by: Douglas Anderson