From: Doug Anderson <dianders@chromium.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Niklas Cassel <nks@flawful.org>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Lina Iyer <ilina@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM: AVS: qcom-cpr: select CONFIG_NVMEM
Date: Mon, 20 Sep 2021 06:37:23 -0700 [thread overview]
Message-ID: <CAD=FV=UYOSNG1we=MaNwqZCLjV9re7hHSvtYR3qmzAaLCvDJ=g@mail.gmail.com> (raw)
In-Reply-To: <20210920100226.1448267-1-arnd@kernel.org>
Hi,
On Mon, Sep 20, 2021 at 3:02 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> nvmem_cell_read_variable_le_u32 is only defined when CONFIG_NVMEM
> is set, otherwise we end up with this build failure:
>
> drivers/soc/qcom/cpr.c: In function 'cpr_populate_ring_osc_idx':
> drivers/soc/qcom/cpr.c:814:23: error: implicit declaration of function 'nvmem_cell_read_variable_le_u32' [-Werror=implicit-function-declaration]
> 814 | ret = nvmem_cell_read_variable_le_u32(drv->dev, fuses->ring_osc, &data);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Select the framwork from Kconfig.
>
> Fixes: 6feba6a62c57 ("PM: AVS: qcom-cpr: Use nvmem_cell_read_variable_le_u32()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/soc/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
A fix should have already landed for this error. See the patch:
https://lore.kernel.org/r/20210830083449.1.I38e95343209fe1f808c3b4860795a00a2b539701@changeid
...and Greg has applied it. I got a message 6 days ago saying it was in:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-linus branch.
That being said, if people think that we should _also_ select NVMEM
for this driver then I have no objections. The use of nvmem in this
driver predates my patch.
-Doug
next prev parent reply other threads:[~2021-09-20 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 10:02 [PATCH] PM: AVS: qcom-cpr: select CONFIG_NVMEM Arnd Bergmann
2021-09-20 13:37 ` Doug Anderson [this message]
2021-09-20 15:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UYOSNG1we=MaNwqZCLjV9re7hHSvtYR3qmzAaLCvDJ=g@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=ilina@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nks@flawful.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).