From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A32C433DF for ; Mon, 29 Jun 2020 20:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E239B20672 for ; Mon, 29 Jun 2020 20:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="flWt2co8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388026AbgF2Ueq (ORCPT ); Mon, 29 Jun 2020 16:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729416AbgF2TWm (ORCPT ); Mon, 29 Jun 2020 15:22:42 -0400 Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81DA8C02E2F7 for ; Mon, 29 Jun 2020 07:33:33 -0700 (PDT) Received: by mail-vs1-xe43.google.com with SMTP id m65so586587vsd.6 for ; Mon, 29 Jun 2020 07:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YNkvAElAdlylwMX22qVeO6w3DffRcKTQ6SjWLKbis1A=; b=flWt2co8UrsGAn5eM02MB8ewGt+er7i6cSZMso4fN8Fq6W1kWGiTyiiCwMe3Y9kVcr o+jJR0GQp8fWNAU8gkgJ7rGcfEMIpoyg3d1Cfas9VtcRMa9pJIE3zkVz+qW3GOh4y1VQ tz4wtTIW837O3y69hcCAC0FmgG92kdYfWdPf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YNkvAElAdlylwMX22qVeO6w3DffRcKTQ6SjWLKbis1A=; b=mNEGZ1FAJiNogKfqF1/wZNTqMbStVaq4ackZzchCvR07tE9aThwc/MAAk7w2CPqP2U HtY8cJ8ssDYCZ8VLB66iiwaCyG6TD4dPe9ew6iks4UPMDzkUkk/zDrpfWpW27FszjDGA L8DGr8ELmebH58iPwmJW2NiYK5NqJHYbqEpt1oN6E6BQG/jPAJicTSM0S3rgODS8oQIA ASUVMHtfLgBbYk0ktoZ51oXlF1eHMNVAHCB7xrorE16iBiBGocyF8CxaQeKGtHBtofwH 5scXGvTj9+ExNY+pcYiNedNY77oT8db7UNbhzzREPBravPI4PlOeHv1fILZa26eq7hTn VvuQ== X-Gm-Message-State: AOAM532aVwH7BCiR/Dmj0ilW5VYooVzu8g2ziRjgGg3spMcVSATAdhmj oB8iirCkBXx0gk+2VAY8fSHBQFNecyg= X-Google-Smtp-Source: ABdhPJwKLv5D3GLp1Mj8vuCU8k/jqjy7c3FsLeP87tKwwAUO2jf3tl/eSTWZkAZrquucFTRh1/FnWg== X-Received: by 2002:a67:bc4:: with SMTP id 187mr1282352vsl.114.1593441212443; Mon, 29 Jun 2020 07:33:32 -0700 (PDT) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id m73sm20509vke.11.2020.06.29.07.33.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 07:33:31 -0700 (PDT) Received: by mail-ua1-f43.google.com with SMTP id c7so3916412uap.0 for ; Mon, 29 Jun 2020 07:33:30 -0700 (PDT) X-Received: by 2002:ab0:29c1:: with SMTP id i1mr10886058uaq.120.1593441210383; Mon, 29 Jun 2020 07:33:30 -0700 (PDT) MIME-Version: 1.0 References: <1593194502-13164-1-git-send-email-pillair@codeaurora.org> <1593194502-13164-3-git-send-email-pillair@codeaurora.org> <000301d64e0e$b9e32c70$2da98550$@codeaurora.org> In-Reply-To: <000301d64e0e$b9e32c70$2da98550$@codeaurora.org> From: Doug Anderson Date: Mon, 29 Jun 2020 07:33:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting To: Rakesh Pillai Cc: Kalle Valo , ath10k@lists.infradead.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-wireless , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jun 29, 2020 at 5:14 AM Rakesh Pillai wrote: > > > > > -----Original Message----- > > From: Doug Anderson > > Sent: Saturday, June 27, 2020 3:22 AM > > To: Rakesh Pillai ; Kalle Valo > > > > Cc: ath10k@lists.infradead.org; open list:OPEN FIRMWARE AND FLATTENED > > DEVICE TREE BINDINGS ; linux-wireless > wireless@vger.kernel.org>; LKML > > Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply > > voting > > > > Hi, > > > > On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai wrote: > > > > > > Add support to vote for chain-1 voltage regulator > > > in WCN3990. > > > > > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > > > > > Signed-off-by: Rakesh Pillai > > > --- > > > drivers/net/wireless/ath/ath10k/snoc.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c > > b/drivers/net/wireless/ath/ath10k/snoc.c > > > index 645ed5f..407a074 100644 > > > --- a/drivers/net/wireless/ath/ath10k/snoc.c > > > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > > > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = { > > > "vdd-1.8-xo", > > > "vdd-1.3-rfa", > > > "vdd-3.3-ch0", > > > + "vdd-3.3-ch1", > > > > Reviewed-by: Douglas Anderson > > > > ...with the slight nit that ${SUBJECT} and description should probably > > call it "chan1" and not "chain1". Presumably the maintainer can fix > > when applying. > > > > -Doug > > Hi Doug, > > It has to be chain1 only, not chan1. > This is the power supply rail for the wlan-chain1 Whoa, really? "ch1" stands for "chain1", not "chan1"? That is seriously weird (at least to me), but I find at least one document that agrees with you. Sorry for the mistake! -Doug