From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031862AbdAFS3Q (ORCPT ); Fri, 6 Jan 2017 13:29:16 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35141 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937702AbdAFS3H (ORCPT ); Fri, 6 Jan 2017 13:29:07 -0500 MIME-Version: 1.0 In-Reply-To: <669c85b1-f0fb-c58e-90a8-3aeac3118656@rock-chips.com> References: <1483608682-226716-1-git-send-email-shawn.lin@rock-chips.com> <1483608682-226716-2-git-send-email-shawn.lin@rock-chips.com> <669c85b1-f0fb-c58e-90a8-3aeac3118656@rock-chips.com> From: Doug Anderson Date: Fri, 6 Jan 2017 10:29:04 -0800 X-Google-Sender-Auth: UQT3LdHDGZbsjdE9LbKUgcLmK7E Message-ID: Subject: Re: [PATCH 2/2] phy: rockchip-emmc: try to get drive impedance from DT To: Shawn Lin Cc: Kishon Vijay Abraham I , Rob Herring , "devicetree@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Heiko Stuebner , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jan 5, 2017 at 5:09 PM, Shawn Lin wrote: > On 2017/1/6 8:51, Doug Anderson wrote: >> >> Hi, >> >> On Thu, Jan 5, 2017 at 1:31 AM, Shawn Lin >> wrote: >>> >>> Try to get drive impedance from DT and use it, otherwise >>> use 50ohm by default in order not to break the existing boards >>> as 50ohm works fine for them already. >>> >>> Signed-off-by: Shawn Lin >>> --- >>> >>> drivers/phy/phy-rockchip-emmc.c | 29 ++++++++++++++++++++++++++++- >>> 1 file changed, 28 insertions(+), 1 deletion(-) >> >> >> I could have sworn that you somehow needed to make sure that the eMMC >> part itself needed to also be updated to be told the matching drive >> impedance so you don't get a mismatch. How do you make that work? > > > No I didn't. So that means the eMMC part itself still couldn't be > updated. The intention for me to introduce this only for emmc phy is > that I got report that the default drive impedance of one eMMC is not > 50ohms, so now we haven't been able to update it for eMMC part but maybe > we could just update it for the phy itself to match them in between. Interesting. ...the eMMC spec says that 50 Ohm is mandatory, so we know that 50 Ohm must be supported. ...and even if the default isn't 50 Ohm then wouldn't it get set to 50 OHm when we set the HS_TIMING ? -Doug