From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED4A3C433EF for ; Fri, 20 May 2022 00:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344009AbiETA11 (ORCPT ); Thu, 19 May 2022 20:27:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232460AbiETA10 (ORCPT ); Thu, 19 May 2022 20:27:26 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B66D9CF5F for ; Thu, 19 May 2022 17:27:25 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id p26so8886141eds.5 for ; Thu, 19 May 2022 17:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q2SsP49FcCChtmjGtwbSaTMmlIgf4FKqMdxkNXcLZxo=; b=HXRvwBSe1kdLw+E5XZQUg1aqD+Xzx1EPDD38vER8o23tEByEWKBd7UsuCsmlQjS2IA UrFRDsWb1JfLL64GhKqULVkddtRl8NXbTC9LPYW7SISZVG8H9KSTco/tZyI1GcTczIEC gnDMhQk9vYaGXJfrN3vT+O6EmsVeRrRGlccwc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q2SsP49FcCChtmjGtwbSaTMmlIgf4FKqMdxkNXcLZxo=; b=ejsFcik0687A5cq2aRXxz8Gacd/018SzxBVPqLcGh49hDgzXn79N+8RJRf/iBMHi9+ OOiypYldNsshsIoP205bPhSgvPevKfNE4fZOYzUAUTHx+NSVfzc9aHveX3n0k6tW8tBm IH2wLwTRh2rJBJwp5HFLAsE4szCsVRdjORCB2lX5ltKEVQvCt3ch6mAUzjCcO799762u vdZGeXnrbJQtfbn6O9kzEYg6xltzRge9zJldeDLS7RMsB96n3t3J6YYWDI6lHhcGboC3 CamJYaliZPfnD2+Tn6JROmnj54wW3jjiBbhx+VkUKQtlqkzjzIr7udnC9u4F85z9UnXE tmOg== X-Gm-Message-State: AOAM530fq+aUlI38EjZEQEEo8FJQgmtUhm3YCdUOVWu0oxyvGYp/zz0C K45VTu/QpdJVwNClXMB8HOy7ReHpe/3mBufMepI= X-Google-Smtp-Source: ABdhPJySMFlBKlUfqcgfVmI+2JYrGOObc2RfBCw/jlPhLcL9ohZOdwdXM06Wyij5DUP95tNkpwLjFg== X-Received: by 2002:aa7:c25a:0:b0:42a:a4f6:4f84 with SMTP id y26-20020aa7c25a000000b0042aa4f64f84mr8370541edo.420.1653006443606; Thu, 19 May 2022 17:27:23 -0700 (PDT) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com. [209.85.218.54]) by smtp.gmail.com with ESMTPSA id el9-20020a170907284900b006f3ef214e55sm2567940ejc.187.2022.05.19.17.27.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 17:27:23 -0700 (PDT) Received: by mail-ej1-f54.google.com with SMTP id kq17so12826823ejb.4 for ; Thu, 19 May 2022 17:27:23 -0700 (PDT) X-Received: by 2002:a5d:6d09:0:b0:20c:53a9:cc30 with SMTP id e9-20020a5d6d09000000b0020c53a9cc30mr5985688wrq.513.1653006043655; Thu, 19 May 2022 17:20:43 -0700 (PDT) MIME-Version: 1.0 References: <20220511155749.v3.1.I2dd93486c6952bd52f2020904de0133970d11b29@changeid> In-Reply-To: <20220511155749.v3.1.I2dd93486c6952bd52f2020904de0133970d11b29@changeid> From: Doug Anderson Date: Thu, 19 May 2022 17:20:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes() To: dri-devel Cc: freedreno , Stephen Boyd , "Kuogee Hsieh (QUIC)" , Sankeerth Billakanti , "Abhinav Kumar (QUIC)" , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Aravind Venkateswaran (QUIC)" , Thomas Zimmermann , Dmitry Baryshkov , Rob Clark , linux-arm-msm , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote: > > The drm_helper_probe_single_connector_modes() is a bit long. Let's > break a chunk off to update and validate modes. This helps avoid one > goto and also will allow us to more easily call the helper a second > time in a future patch without adding looping or another goto. > > This change is intended to be a no-op change--just code movement. > > Signed-off-by: Douglas Anderson > Reviewed-by: Abhinav Kumar > Reviewed-by: Thomas Zimmermann > --- > > Changes in v3: > - Removed WARN_ON > > Changes in v2: > - Two underscores for __drm_helper_update_and_validate(). > - Return err and use WARN_ON instead of returning a bool. > > drivers/gpu/drm/drm_probe_helper.c | 106 ++++++++++++++++------------- > 1 file changed, 60 insertions(+), 46 deletions(-) Pushed to drm-misc-next: 4a2a13a57b60 drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()