From: Doug Anderson <dianders@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices
Date: Mon, 15 Mar 2021 10:27:14 -0700 [thread overview]
Message-ID: <CAD=FV=Uvtdrb7N=UX2+XwNnYJd3_JWjrnjcMVnH=A3xq4oFQQw@mail.gmail.com> (raw)
In-Reply-To: <20210312234310.3490809-1-bjorn.andersson@linaro.org>
Hi,
On Fri, Mar 12, 2021 at 3:42 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> The reserved-memory regions used for carrying firmware to be run on the
> various cores and co-processors in a Qualcomm platform differs in size,
> placement and presence based on each device's feature set and security
> configuration.
>
> Rather than providing some basic set that works on the MTP and then
> piecemeal patch this up on the various devices, push the configuration
> of these regions out to the individual device dts files.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - Added lost memory-region to the db845c wlan node, as spotted by Doug.
>
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 90 +++++++++++++------
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 87 ++++++++++++++++++
> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 87 ++++++++++++++++++
> .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 78 +++++++++++++++-
> .../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 45 ++++++----
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 83 -----------------
> .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 86 ++++++++++++++++++
> 7 files changed, 431 insertions(+), 125 deletions(-)
I will leave it up to you to evaluate Konrad's feedback that this will
cause a bunch of duplication since I don't have enough experience w/
Android phones to have an informed opinion. In case it matters, this
addresses the feedback I had on v1 and thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I'll also repeat the feedback that I had on v1 that I focused much
more on cheza than on other boards and didn't check every last thing
on every board to make sure no changes happened.
next prev parent reply other threads:[~2021-03-15 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 23:43 [PATCH v2 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices Bjorn Andersson
2021-03-12 23:43 ` [PATCH v2 2/2] arm64: dts: qcom: sdm850-yoga: Enable IPA Bjorn Andersson
2021-03-13 2:35 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices Konrad Dybcio
2021-03-24 1:32 ` Bjorn Andersson
2021-03-15 17:27 ` Doug Anderson [this message]
2021-03-18 18:41 ` Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Uvtdrb7N=UX2+XwNnYJd3_JWjrnjcMVnH=A3xq4oFQQw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).