From: Doug Anderson <dianders@chromium.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
perex@perex.cz, tiwai@suse.de,
"Sonny Rao" <sonnyrao@chromium.org>,
"Heiko Stübner" <heiko@sntech.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
alsa-devel@alsa-project.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec
Date: Tue, 2 Dec 2014 09:54:39 -0800 [thread overview]
Message-ID: <CAD=FV=Uwb1NxxCoXHzHu6DJCpnG_HV2RhCr3JaJaXbJja8kd7A@mail.gmail.com> (raw)
In-Reply-To: <1417531977-30094-1-git-send-email-jay.xu@rock-chips.com>
Jianqun,
This ought to be a "v3" patch and ideally ought to describe
differences from v2 (after the cut). Please have Kever or Chris
review your next patch before sending it out since I think they are
familiar with the process.
On Tue, Dec 2, 2014 at 6:52 AM, Jianqun Xu <jay.xu@rock-chips.com> wrote:
> From: Sonny Rao <sonnyrao@chromium.org>
>
> We need to claim the clock which is driving the codec so that when we enable
> clock gating, we continue to clock the codec when needed. I make this an
> optional clock since there might be some applications where we don't need it
> but can still use the I2S block.
>
> Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
You still forgot your own signed-off-by. Please try again. See
<https://patchwork.kernel.org/patch/5334991/>
> + i2s->oclk = devm_clk_get(&pdev->dev, "i2s_clk_out");
> + if (IS_ERR(i2s->oclk)) {
> + dev_dbg(&pdev->dev, "Didn't find output clock\n");
> + i2s->oclk = NULL;
> + }
You still forgot the blank line here requested by Heiko. Please try
again. See <https://patchwork.kernel.org/patch/5334991/>
> + if (i2s->oclk)
> + ret = clk_prepare_enable(i2s->oclk);
> +
next prev parent reply other threads:[~2014-12-02 17:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 14:49 [PATCH 0/2] rockchip: i2s: patches to add optional clock output from Jianqun Xu
2014-12-02 14:49 ` [PATCH 1/2] ASoC: rockchip-i2s: dt: add an optional property "i2s_clk_out" Jianqun Xu
2014-12-02 17:57 ` Doug Anderson
2014-12-02 14:52 ` [PATCH 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec Jianqun Xu
2014-12-02 17:54 ` Doug Anderson [this message]
2014-12-03 1:03 ` Jianqun
2014-12-03 5:18 ` Doug Anderson
2014-12-03 12:55 ` Mark Brown
2014-12-03 7:18 ` [PATCH v2 0/2] ASoC: rockchip: i2s: driver could output "i2s-clk-out" optionally Jianqun Xu
2014-12-03 7:18 ` [PATCH v2 1/2] ASoC: dt-bindings: rockchip-i2s: add an optional property "i2s_clk_out" Jianqun Xu
2014-12-03 7:18 ` [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec Jianqun Xu
2014-12-03 19:20 ` Mark Brown
2014-12-03 19:38 ` Sonny Rao
2014-12-03 20:03 ` Mark Brown
2014-12-03 23:03 ` Sonny Rao
2014-12-03 23:22 ` [alsa-devel] " Dylan Reid
2014-12-03 23:52 ` Sonny Rao
-- strict thread matches above, loose matches on Subject: below --
2014-11-19 3:06 [PATCH 0/2] " Jianqun Xu
2014-11-19 3:07 ` [PATCH 2/2] " Jianqun Xu
2014-11-19 3:57 ` Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Uwb1NxxCoXHzHu6DJCpnG_HV2RhCr3JaJaXbJja8kd7A@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=sonnyrao@chromium.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).