From: Doug Anderson <dianders@chromium.org>
To: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
quic_msavaliy@quicinc.com, Matthias Kaehlcke <mka@chromium.org>,
Stephen Boyd <swboyd@chromium.org>
Subject: Re: [V4] serial: core: Do stop_rx in suspend path for console if console_suspend is disabled
Date: Fri, 3 Jun 2022 12:28:38 -0700 [thread overview]
Message-ID: <CAD=FV=UyNgfYe2Xh3uuYYHB4yPajZKO+i8nCngFn7TedbF-piA@mail.gmail.com> (raw)
In-Reply-To: <f525c352-d995-0589-584f-0e9acf419f80@quicinc.com>
Hi,
On Fri, Jun 3, 2022 at 11:54 AM Vijaya Krishna Nivarthi
<quic_vnivarth@quicinc.com> wrote:
>
> >>> Add a start_rx in uart_resume_port after call to set_termios to handle
> >>> this scenario for other drivers.
>
> Since start_rx is not exposed it doesn't seem like we will be able to
> handle it in core.
>
> In your drivers, Can we add a call to stop_rx at begin of set_termios
> and then undo it at end?
>
> That would ensure that set_termios functionality is unaffected while
> fixing the broken cases?
>
> If that's not an option we will have to go back to a previous version of
> limiting the change to qcom driver.
How about this: add an optional start_rx() callback to "struct
uart_ops" and then only do your stop_rx() logic in uart_suspend_port()
if you'll be able to start it again (AKA if the start_rx() callback is
not NULL). That keeps the logic in the core.
-Doug
next prev parent reply other threads:[~2022-06-03 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 9:20 [V4] serial: core: Do stop_rx in suspend path for console if console_suspend is disabled Vijaya Krishna Nivarthi
[not found] ` <CGME20220523213246eucas1p2d0da08d931a996cd3410eda1c2fd48c0@eucas1p2.samsung.com>
2022-05-23 21:32 ` Marek Szyprowski
[not found] ` <CGME20220524115408eucas1p1ddda7aae4db0a65a7d67d6f8c59d404b@eucas1p1.samsung.com>
2022-05-24 11:54 ` Marek Szyprowski
2022-06-01 11:24 ` Vijaya Krishna Nivarthi
2022-06-01 22:25 ` Marek Szyprowski
2022-06-02 15:42 ` Vijaya Krishna Nivarthi
2022-06-03 18:54 ` Vijaya Krishna Nivarthi
2022-06-03 19:28 ` Doug Anderson [this message]
2022-06-06 12:30 ` Vijaya Krishna Nivarthi
2022-06-07 13:22 ` Greg KH
2022-06-07 13:25 ` Vijaya Krishna Nivarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UyNgfYe2Xh3uuYYHB4yPajZKO+i8nCngFn7TedbF-piA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mka@chromium.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).