From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933096AbcFJQkK (ORCPT ); Fri, 10 Jun 2016 12:40:10 -0400 Received: from mail-vk0-f44.google.com ([209.85.213.44]:34758 "EHLO mail-vk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbcFJQkF (ORCPT ); Fri, 10 Jun 2016 12:40:05 -0400 MIME-Version: 1.0 In-Reply-To: <20160610134217.GA25881@rob-hp-laptop> References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386765-27867-1-git-send-email-ykk@rock-chips.com> <20160610134217.GA25881@rob-hp-laptop> From: Doug Anderson Date: Fri, 10 Jun 2016 09:40:03 -0700 X-Google-Sender-Auth: x1ZXDg5xpPW1DTVlr3WJx4WKTcQ Message-ID: Subject: Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding To: Rob Herring Cc: Yakir Yang , David Airlie , Thierry Reding , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob, On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring wrote: > On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: >> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel >> connected using eDP interfaces. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v2: >> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 >> >> .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> new file mode 100644 >> index 0000000..81938c0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> @@ -0,0 +1,7 @@ >> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "sharp,lq123p1jx31," > ^ > Need to drop the comma. Thanks for catching! > No regulators or resets or pwms? Could be more explicit I guess, but Yakir does say: > This binding is compatible with the simple-panel binding, which is specified > in simple-panel.txt in this directory. In that document it shows: Required properties: - power-supply: regulator to provide the supply voltage Optional properties: - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing - enable-gpios: GPIO pin to enable or disable the panel - backlight: phandle of the backlight device attached to the panel In general Yakir's bindings document match a huge chunk of the current existing bindings. Do this: cd Documentation/devicetree/bindings/display/panel grep -C20 "This binding is compatible with the simple-panel" * You'll find a huge chunk of files which are rather formulaic. It might make sense to just have one file and a list of panels which are simple panels? -Doug