From: Doug Anderson <dianders@chromium.org>
To: addy ke <addy.ke@rock-chips.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Seungwon Jeon" <tgih.jun@samsung.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Chris Ball" <chris@printf.net>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Dinh Nguyen" <dinguyen@altera.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Olof Johansson" <olof@lixom.net>,
"Sonny Rao" <sonnyrao@chromium.org>,
"Alexandru Stan" <amstan@chromium.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"zhenfu.fang" <zhenfu.fang@rock-chips.com>,
"Eddie Cai" <cf@rock-chips.com>, lintao <lintao@rock-chips.com>,
chenfen <chenfen@rock-chips.com>, zyf <zyf@rock-chips.com>,
"Jianqun Xu" <xjq@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>, Chris <zyw@rock-chips.com>,
姚智情 <yzq@rock-chips.com>, "han jiang" <hj@rock-chips.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
zhangqing <zhangqing@rock-chips.com>,
"Lin Huang" <hl@rock-chips.com>
Subject: Re: [PATCH v2] mmc: dw_mmc: add quirk for broken data transfer over scheme
Date: Tue, 2 Dec 2014 09:47:18 -0800 [thread overview]
Message-ID: <CAD=FV=V3BF8qv17n4_T5Lys1BnKsqE9NqOTB-6OwX0VOviWRrw@mail.gmail.com> (raw)
In-Reply-To: <547D6F36.50103@rock-chips.com>
Addy,
On Mon, Dec 1, 2014 at 11:50 PM, addy ke <addy.ke@rock-chips.com> wrote:
> We don't know why we have this problem,
> but this problem is really exist, and we need patch to fix this problem now.
> I will post a follow up change when we find the root cause.
To me that seems reasonable. Certainly I would prefer to have this
patch while waiting for the root cause, but it's up to Ulf.
> And there is a little probability of this problem on RK SoC, such as RK3188, RK3066,
> when worse card inserted in.
> Maybe the other SoCs have the similar problem.
>
> So I will add this quirk in rockchip code(dw_mmc-rockchip.c) as follows:
> static int dw_mci_rockchip_parse_dt(struct dw_mci *host)
> {
> host->quirk |= DW_MCI_QUIRK_BROKEN_DTO;
>
> return 0;
> }
>
> ......
> .parse_dt = dw_mci_rockchip_parse_dt,
> ......
>
> is right?
When you added "sdio_id0" you got feedback that you should use
dw_mci_rockchip_init(). Why not do the same thing here?
next prev parent reply other threads:[~2014-12-02 17:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 13:05 [PATCH] mmc: dw_mmc: add quirk for data over interrupt timeout Addy Ke
2014-11-14 13:18 ` Jaehoon Chung
2014-11-18 0:32 ` Addy
2014-11-19 1:22 ` Jaehoon Chung
2014-11-19 5:56 ` addy ke
2014-11-20 9:33 ` addy ke
2014-11-20 10:01 ` Jaehoon Chung
2014-11-25 6:30 ` Addy
2014-11-25 8:10 ` [PATCH v2] mmc: dw_mmc: add quirk for broken data transfer over scheme Addy Ke
2014-11-26 22:46 ` Doug Anderson
2014-12-02 7:50 ` addy ke
2014-12-02 17:47 ` Doug Anderson [this message]
2014-12-03 3:16 ` [PATCH v3] " Addy Ke
2014-12-03 5:08 ` Doug Anderson
2014-12-05 23:56 ` Alexandru Stan
2014-12-26 9:13 ` [PATCH v4] " Addy Ke
2015-01-05 8:21 ` [PATCH v5] " Addy Ke
2015-01-08 1:58 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=V3BF8qv17n4_T5Lys1BnKsqE9NqOTB-6OwX0VOviWRrw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=addy.ke@rock-chips.com \
--cc=amstan@chromium.org \
--cc=cf@rock-chips.com \
--cc=chenfen@rock-chips.com \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=hj@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jh80.chung@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=lintao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zhenfu.fang@rock-chips.com \
--cc=zyf@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).