From: Doug Anderson <dianders@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: David Collins <collinsd@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v9 2/2] regulator: add QCOM RPMh regulator driver
Date: Fri, 10 Aug 2018 13:07:14 -0700 [thread overview]
Message-ID: <CAD=FV=V54aOCTLk3J_0=DL0XHJ-Tc77zKzURTwz5PJsioK73+A@mail.gmail.com> (raw)
In-Reply-To: <20180810162920.GG20971@sirena.org.uk>
Hi,
On Fri, Aug 10, 2018 at 9:29 AM, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Jul 13, 2018 at 06:50:59PM -0700, David Collins wrote:
>
>> + switch (rpmh_mode) {
>
>> + default:
>> + mode = REGULATOR_MODE_INVALID;
>> + }
>
> I'm not sure why the break statements are being omitted in default
> cases, but I do find myself stopping and trying to figure it out?
Hopefully <https://lore.kernel.org/lkml/20180810200531.88409-1-dianders@chromium.org/>
addresses this?
Thanks!
-Doug
prev parent reply other threads:[~2018-08-10 20:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 1:50 [PATCH v9 0/2] regulator: add QCOM RPMh regulator driver David Collins
2018-07-14 1:50 ` [PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings David Collins
2018-07-23 20:09 ` Doug Anderson
2018-07-24 14:57 ` Mark Brown
2018-07-24 15:11 ` Doug Anderson
2018-07-24 15:25 ` Mark Brown
2018-07-24 15:43 ` Doug Anderson
2018-07-24 16:59 ` Mark Brown
2018-07-26 18:39 ` Andy Gross
2018-08-06 22:55 ` Doug Anderson
2018-08-06 23:55 ` Mark Brown
2018-07-14 1:50 ` [PATCH v9 2/2] regulator: add QCOM RPMh regulator driver David Collins
2018-08-10 16:29 ` Mark Brown
2018-08-10 20:07 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=V54aOCTLk3J_0=DL0XHJ-Tc77zKzURTwz5PJsioK73+A@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).