From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D329C07E99 for ; Mon, 12 Jul 2021 13:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CDC9601FE for ; Mon, 12 Jul 2021 13:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234677AbhGLNss (ORCPT ); Mon, 12 Jul 2021 09:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhGLNsr (ORCPT ); Mon, 12 Jul 2021 09:48:47 -0400 Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CFE9C0613DD for ; Mon, 12 Jul 2021 06:45:58 -0700 (PDT) Received: by mail-ua1-x935.google.com with SMTP id r9so7226540ual.7 for ; Mon, 12 Jul 2021 06:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/y3AswAn7xrfStWckKQ4mdfAYQv8LuashoWFVm7wmnI=; b=JIUoCU9T0XfyuPyJPuVrcxCa8UoWsH/qeP/iWmQomkfVNKt6Mnzy8lEYTsbBLAjQDY qA2lrYcGl7R7GwRo7zb4EcRYe0d2sy5LWLilGAQERXHWRpwcRsU4AXvQl2DgNurV6j9N GaO1ghyx3qKRzIY5oEx/5Ib8QbPhKF1MbPyX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/y3AswAn7xrfStWckKQ4mdfAYQv8LuashoWFVm7wmnI=; b=iauZQ8ISnqGMT7SEJpxH6ILo5pvWv4ofnWMOJPN+/dqlSecDNUQga/TGCKwGvqXxhT 2JVFZ7eTaiyhrsXXyumVi5r659L3EBCLzUoF6iONoM1vYziuGKF3vaWkjd4T6cwQneAS DmvUKnXQcU2F/v89fD+ojW2esYv3+gGywePTW0zP3DUbhdhuJ+Om+93gn+MC6NLXceNK 7lCAqphfuR3WXqvopouA12ebplNgyGzMuDEeeBT6PBeHI7f0Em7znBfYb0jy7DRRiViC JAuNJS3LYsG/mIN/Kjkp4VaFUtKao2uuyewG7ELyiYphzT3zvqzvlq3bQDEoRnVtHbmD XCxw== X-Gm-Message-State: AOAM530xhhmEfBETZWWmxKQX5h1rEE+JmqmiZlvRBnMwx2ha+XaZlZhG yQtrK+AwjTcMROU65QLY8bEw1UFDTx77Iw== X-Google-Smtp-Source: ABdhPJxcJHGk6UsIyNFSfSQU+HSGPNCN/Mg54R0afC4e68iCQu8ihw91JCKPRoEzOk9ww3rBnD58lA== X-Received: by 2002:ab0:1e8b:: with SMTP id o11mr27920698uak.49.1626097557223; Mon, 12 Jul 2021 06:45:57 -0700 (PDT) Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com. [209.85.222.48]) by smtp.gmail.com with ESMTPSA id w4sm2019913vsk.30.2021.07.12.06.45.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 06:45:57 -0700 (PDT) Received: by mail-ua1-f48.google.com with SMTP id d2so7239638uan.0 for ; Mon, 12 Jul 2021 06:45:57 -0700 (PDT) X-Received: by 2002:a25:3486:: with SMTP id b128mr71633896yba.523.1626097181672; Mon, 12 Jul 2021 06:39:41 -0700 (PDT) MIME-Version: 1.0 References: <1624726268-14869-1-git-send-email-rajeevny@codeaurora.org> <1624726268-14869-2-git-send-email-rajeevny@codeaurora.org> <7f8562df-7e1f-dcfb-1c58-f1edd9dcc606@suse.de> In-Reply-To: <7f8562df-7e1f-dcfb-1c58-f1edd9dcc606@suse.de> From: Doug Anderson Date: Mon, 12 Jul 2021 06:39:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v8 1/6] drm/panel: add basic DP AUX backlight support To: Thomas Zimmermann Cc: Rajeev Nandan , dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Thierry Reding , Sam Ravnborg , Rob Clark , Lyude Paul , Jani Nikula , Rob Herring , Laurent Pinchart , Andrzej Hajda , Daniel Thompson , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan , Lee Jones , Jingoo Han , linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > + EDP_DISPLAY_CTL_CAP_SIZE); > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > drm_panel.c is in the latter, while drm_dp_dpcd_read() in > drm_dp_helper.c is in the former. Please fix. Yeah, this was reported Friday and I posted a patch to try to fix it: https://lore.kernel.org/lkml/20210709152909.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/ I see Rajeev had some feedback on it. Once I've dug out of my weekend email hole I'll take a look at plan to post a v2 ASAP. -Doug