From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D2F0C4338F for ; Fri, 23 Jul 2021 16:44:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A05B60200 for ; Fri, 23 Jul 2021 16:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhGWQDa (ORCPT ); Fri, 23 Jul 2021 12:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbhGWQD3 (ORCPT ); Fri, 23 Jul 2021 12:03:29 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D3C1C06175F for ; Fri, 23 Jul 2021 09:44:01 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id d17so1578778qvn.13 for ; Fri, 23 Jul 2021 09:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oc8CK0AsdZszsESWwjfIrhAjbLc742tCwBqHvOldIcY=; b=IRarJsCDT60AoiiLdZaWY9Pa53CuNALBm89bNCTf1K9FWkoWh6vFzafpzU6XniduLG K5+jk+ECPltATP2sQMwwxwAOgRWv97d+wXenryGCyyQX5533M5MdwD4sjcj1M+MZf+1b ba5fA9gkLqmdHNJtf7/hPBseKbHcrQfDb8nAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oc8CK0AsdZszsESWwjfIrhAjbLc742tCwBqHvOldIcY=; b=sZzYiKqwET6oSkFwfc+FP3Lfx83xgcbLOmVUoVPHREJg+hv4Jj6RvDg3s9bvIfpg9j K8NAu5p0av7Hlff3OjnKXlsgraNa338ZPifsHytaLcA4Ix8LwZifNkk5ywabINse2H/t fM77CdcgDaAsPCzCplVMG+5wkGOe9oV+IpqKjDjDhD23fr7+USMoAVPuG5op4NUSwAZ6 eBsdmaBk5PWBDEVBZOSoh/7di/7LFKf3iTNW/V2f5jWuBWNbXpR/vSxvg6WOfvSvmnPY jFWIjIdmRoF7smTeAQD6HMqS6qHZ2aq9NZOAM9vtImjb3CSudRJ5MgqBw1oJu8Qboode /Nsg== X-Gm-Message-State: AOAM5304cMH7V45bK/lf6O0zQgHWwahKo917gXUz9EgNdUTTbSYo4fDn q4PnXll3xG+ogp1S2OYBPUUearWSZUrSKA== X-Google-Smtp-Source: ABdhPJwl6CrZVQzJBG0jnLcfbKLuPYttZhPOwz2tJYhP5svmTfacGJoPW4pS7q0eenJQdYX/haRbCA== X-Received: by 2002:a0c:c2d3:: with SMTP id c19mr5428476qvi.62.1627058640137; Fri, 23 Jul 2021 09:44:00 -0700 (PDT) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id d16sm11516711qtj.69.2021.07.23.09.43.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 09:43:59 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id a201so3198603ybg.12 for ; Fri, 23 Jul 2021 09:43:58 -0700 (PDT) X-Received: by 2002:a05:6902:521:: with SMTP id y1mr7959636ybs.32.1627058638294; Fri, 23 Jul 2021 09:43:58 -0700 (PDT) MIME-Version: 1.0 References: <1626931716-10591-1-git-send-email-rnayak@codeaurora.org> <1626931716-10591-3-git-send-email-rnayak@codeaurora.org> In-Reply-To: <1626931716-10591-3-git-send-email-rnayak@codeaurora.org> From: Doug Anderson Date: Fri, 23 Jul 2021 09:43:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] nvmem: qfprom: sc7280: Handle the additional power-domains vote To: Rajendra Nayak Cc: Andy Gross , Bjorn Andersson , Srinivas Kandagatla , Rob Herring , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , "Ravi Kumar Bokka (Temp)" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jul 21, 2021 at 10:29 PM Rajendra Nayak wrote: > > On sc7280, to reliably blow fuses, we need an additional vote > on max performance state of 'MX' power-domain. > Add support for power-domain performance state voting in the > driver. > > Signed-off-by: Rajendra Nayak > --- > drivers/nvmem/qfprom.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c > index 81fbad5..4d0a576 100644 > --- a/drivers/nvmem/qfprom.c > +++ b/drivers/nvmem/qfprom.c > @@ -12,6 +12,8 @@ > #include > #include > #include > +#include > +#include > #include > #include > > @@ -149,6 +151,11 @@ static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv, > if (ret) > dev_warn(priv->dev, "Failed to set 0 voltage (ignoring)\n"); > > + if (priv->dev->pm_domain) { > + dev_pm_genpd_set_performance_state(priv->dev, 0); > + pm_runtime_put(priv->dev); > + } > + > ret = regulator_disable(priv->vcc); > if (ret) > dev_warn(priv->dev, "Failed to disable regulator (ignoring)\n"); > @@ -212,6 +219,16 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv, > goto err_clk_rate_set; > } > > + if (priv->dev->pm_domain) { > + ret = pm_runtime_get_sync(priv->dev); > + if (ret < 0) { > + pm_runtime_put_noidle(priv->dev); > + dev_err(priv->dev, "Failed to enable power-domain\n"); > + goto err_reg_enable; > + } > + dev_pm_genpd_set_performance_state(priv->dev, INT_MAX); > + } > + > old->timer_val = readl(priv->qfpconf + QFPROM_BLOW_TIMER_OFFSET); > old->accel_val = readl(priv->qfpconf + QFPROM_ACCEL_OFFSET); > writel(priv->soc_data->qfprom_blow_timer_value, > @@ -221,6 +238,8 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv, > > return 0; > > +err_reg_enable: > + regulator_disable(priv->vcc); > err_clk_rate_set: > clk_set_rate(priv->secclk, old->clk_rate); > err_clk_prepared: > @@ -420,6 +439,9 @@ static int qfprom_probe(struct platform_device *pdev) > econfig.reg_write = qfprom_reg_write; > } > > + if (dev->pm_domain) > + pm_runtime_enable(dev); > + Where is the matching pm_runtime_disable()? Should be one in .remove(), or use devm_add_action_or_reset() to wrap a call to it. Also: do you really need to test for dev->pm_domain in your patch? Seems like it should always be fine to call pm_runtime_enable() and then always fine to call the get/put. ...and presumably always fine to even set the performance state? -Doug