From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F9BC2BB1D for ; Wed, 11 Mar 2020 23:03:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 827E720691 for ; Wed, 11 Mar 2020 23:03:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Yvv0M1bg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731425AbgCKXDG (ORCPT ); Wed, 11 Mar 2020 19:03:06 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:44060 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729739AbgCKXDG (ORCPT ); Wed, 11 Mar 2020 19:03:06 -0400 Received: by mail-vs1-f68.google.com with SMTP id u24so2485700vso.11 for ; Wed, 11 Mar 2020 16:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qmAU44+2WU5M+59/aGW/KF6T8HFXFFftVV4HYKoIqRE=; b=Yvv0M1bgxd0+ERo0T6RSS7KQwRTXvbLHmgh2GQU5LakeLf2u1+Tai8IP0P527bIzhV O552i21SYvZxu2Cv6WF/RqUWq91rqHvEaVLNoSMziNgZgVrQj4uj35thKw0eQswsd+xo EAcEcgawzWEd8hFZMNxCcxU03p2CMf1MDCEy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qmAU44+2WU5M+59/aGW/KF6T8HFXFFftVV4HYKoIqRE=; b=QJ/e1eVkJSOe6FmY72TTMYKyDEGGlofbuODbOgtWXaK3VN4gIv/58op3Li86JEnOoU rSqZyxz804pkceJTCSvVGI+z7UcHOgYkCXZET7OTQALYscCYPGov8fgk5ULR1vmrjsi8 PKODvBPTQt8GUa51Eyta/M1Aqv0dHBMfd/rnvyyokEo9MGkK0D7dVgVyabRUQWWCBqIV 6jZJZXH/3GdvkN0sOGnM6PqiELQhQ4l9pzPiQj/5oWlD1zamnlT+95Sjk3l5iv/XJNzk FAphz8Ldd2mHUh2bUOUvhCPI+IrJ0HUnrpjPZDxfnX4n+nJ9IYha21EeiOfltLYwTrhe mMSQ== X-Gm-Message-State: ANhLgQ05DoaeBMf08McN+XSeEeFPnLB44yelLwypSQpWMNF0mj8186MW XtC05BFLmye5sEzAj7UKSJPdY1K4CiM= X-Google-Smtp-Source: ADFU+vvlO7pm1XhqfE6MtSRQ68VFc0ehKNDTkLz2cFa+qHC0y5FNhqcJL+ZhM2Q7bXwCNPpvUEbsjw== X-Received: by 2002:a67:d706:: with SMTP id p6mr3771184vsj.143.1583967783085; Wed, 11 Mar 2020 16:03:03 -0700 (PDT) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com. [209.85.217.41]) by smtp.gmail.com with ESMTPSA id e21sm2776362uan.1.2020.03.11.16.03.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2020 16:03:01 -0700 (PDT) Received: by mail-vs1-f41.google.com with SMTP id t10so2515876vsp.1 for ; Wed, 11 Mar 2020 16:03:00 -0700 (PDT) X-Received: by 2002:a67:e98e:: with SMTP id b14mr3639376vso.106.1583967780416; Wed, 11 Mar 2020 16:03:00 -0700 (PDT) MIME-Version: 1.0 References: <1583746236-13325-1-git-send-email-mkshah@codeaurora.org> <1583746236-13325-6-git-send-email-mkshah@codeaurora.org> In-Reply-To: <1583746236-13325-6-git-send-email-mkshah@codeaurora.org> From: Doug Anderson Date: Wed, 11 Mar 2020 16:02:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 5/5] drivers: qcom: Update rpmh clients to use start and end transactions To: Maulik Shah Cc: Stephen Boyd , Matthias Kaehlcke , Evan Green , Bjorn Andersson , LKML , linux-arm-msm , Andy Gross , Rajendra Nayak , Lina Iyer , lsrao@codeaurora.org, Taniya Das , Odelu Kukatla , Kiran Gunda , Sibi Sankar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Mar 9, 2020 at 2:31 AM Maulik Shah wrote: > > --- a/drivers/interconnect/qcom/bcm-voter.c > +++ b/drivers/interconnect/qcom/bcm-voter.c > @@ -263,7 +263,9 @@ int qcom_icc_bcm_voter_commit(struct bcm_voter *voter) > tcs_list_gen(&voter->commit_list, QCOM_ICC_BUCKET_AMC, cmds, commit_idx); > > if (!commit_idx[0]) > - goto out; > + goto end; > + > + rpmh_start_transaction(voter-dev); > > ret = rpmh_invalidate(voter->dev); > if (ret) { > @@ -312,12 +314,15 @@ int qcom_icc_bcm_voter_commit(struct bcm_voter *voter) > tcs_list_gen(&voter->commit_list, QCOM_ICC_BUCKET_SLEEP, cmds, commit_idx); > > ret = rpmh_write_batch(voter->dev, RPMH_SLEEP_STATE, cmds, commit_idx); > - if (ret) { > + if (ret) > pr_err("Error sending SLEEP RPMH requests (%d)\n", ret); > - goto out; > - } > > out: > + ret = rpmh_end_transaction(voter-dev); One last note is that your code doesn't actually compile for me since you need "voter->dev" here (and in the start case), not "voter-dev". -Doug