From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbdB1X0d (ORCPT ); Tue, 28 Feb 2017 18:26:33 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35807 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbdB1XZF (ORCPT ); Tue, 28 Feb 2017 18:25:05 -0500 MIME-Version: 1.0 In-Reply-To: <6978416.eyJmBK6ozI@phil> References: <20170210010521.78872-1-briannorris@chromium.org> <20170210010521.78872-5-briannorris@chromium.org> <6978416.eyJmBK6ozI@phil> From: Doug Anderson Date: Tue, 28 Feb 2017 14:54:33 -0800 X-Google-Sender-Auth: gu3Mgt83kSVCrv9pFPUjFkFo9y0 Message-ID: Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: add Gru/Kevin DTS To: Heiko Stuebner Cc: Brian Norris , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" , Caesar Wang , "devicetree@vger.kernel.org" , Rob Herring , Stephen Barber , "linux-arm-kernel@lists.infradead.org" , Chris Zhong Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Feb 28, 2017 at 2:00 PM, Heiko Stuebner wrote: >> + pp3300_wifi_bt: pp3300-wifi-bt { >> + compatible = "regulator-fixed"; >> + regulator-name = "pp3300_wifi_bt"; >> + /* NOTE: wlan_module_pd_l pinctrl in pp1800_pcie */ >> + >> + enable-active-high; >> + >> + /* NOTE: this GPIO also used in pp1800_pcie */ > > does the gpio subsystem like this double usage? Yes, see commit f19b00da8ed3 ("regulator: core: support shared enable GPIO concept"). ...but there's no great place to put the pinctrl node though, unfortunately. It's either randomly pick one of the two or add it as a system-level hog. -Doug