From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 3/3] pinctrl: msm: Configure interrupts as input and gpio mode
Date: Tue, 19 Jun 2018 08:48:13 -0700 [thread overview]
Message-ID: <CAD=FV=VfGkOepP3KgYXZLq5esy6rWLr8zf8xiYoPOPN5vmCgGA@mail.gmail.com> (raw)
In-Reply-To: <20180618205255.246104-4-swboyd@chromium.org>
Hi,
On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd <swboyd@chromium.org> wrote:
> When requesting a gpio as an interrupt, we should make sure to mux the
> pin as the GPIO function and configure it to be an input so that various
> functions or output signals don't affect the interrupt state of the pin.
> So far, we've relied on pinmux configurations in DT to handle this, but
> let's explicitly configure this in the code so that DT implementers
> don't have to get this part right.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 37 ++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
This seems like a reasonable idea to me. I'm not a huge fan of all
the boilerplate code copied from gpiochip_irq_reqres() and
gpiochip_irq_relres(), but it looks like that's the way it's done at
the moment. Thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
prev parent reply other threads:[~2018-06-19 15:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 20:52 [PATCH 0/3] pinctrl: msm interrupt and muxing fixes Stephen Boyd
2018-06-18 20:52 ` [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching Stephen Boyd
2018-06-18 22:43 ` Doug Anderson
2018-06-18 23:28 ` Stephen Boyd
2018-06-18 23:38 ` Doug Anderson
2018-06-19 21:14 ` Stephen Boyd
2018-06-20 6:45 ` Bjorn Andersson
2018-06-20 15:52 ` Doug Anderson
2018-06-21 15:14 ` Stephen Boyd
2018-06-22 17:56 ` Bjorn Andersson
2018-06-18 20:52 ` [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request() Stephen Boyd
2018-06-18 23:54 ` Doug Anderson
2018-06-19 21:18 ` Stephen Boyd
2018-06-19 21:38 ` Doug Anderson
2018-06-20 5:53 ` Stephen Boyd
2018-06-22 17:58 ` Bjorn Andersson
2018-06-22 18:31 ` Bjorn Andersson
2018-06-28 14:25 ` Linus Walleij
2018-06-28 17:14 ` Stephen Boyd
2018-06-28 18:45 ` Doug Anderson
2018-07-02 17:56 ` Stephen Boyd
2018-07-09 13:54 ` Linus Walleij
2018-07-09 15:37 ` Stephen Boyd
2018-07-13 6:59 ` Linus Walleij
2018-07-02 19:09 ` Bjorn Andersson
2018-07-06 17:23 ` Stephen Boyd
2018-06-18 20:52 ` [PATCH 3/3] pinctrl: msm: Configure interrupts as input and gpio mode Stephen Boyd
2018-06-19 15:48 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VfGkOepP3KgYXZLq5esy6rWLr8zf8xiYoPOPN5vmCgGA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).