From: Doug Anderson <dianders@chromium.org>
To: Owen Yang <ecs.taipeikernel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Abner Yen <abner.yen@ecs.corp-partner.google.com>,
Gavin Lee <gavin.lee@ecs.corp-partner.google.com>,
Harvey <hunge@google.com>, Matthias Kaehlcke <mka@google.com>,
Stephen Boyd <swboyd@chromium.org>,
Bob Moragues <moragues@google.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: arm: qcom: Add zombie
Date: Mon, 28 Nov 2022 08:58:48 -0800 [thread overview]
Message-ID: <CAD=FV=VqXEONnSOyFLHcM4Z9+6+bVnqjbd_24M9LAoAsWy-L=A@mail.gmail.com> (raw)
In-Reply-To: <20221125174415.v5.1.Idfcba5344b7995b44b7fa2e20f1aa4351defeca6@changeid>
Hi,
On Fri, Nov 25, 2022 at 1:44 AM Owen Yang <ecs.taipeikernel@gmail.com> wrote:
>
> Add an entry in the device tree binding for sc7280-zombie.
Probably not worth spinning the patch for, but previously [0] Matthias
requested that you say "Add entries" instead of "Add an entry". Please
don't ignore reviewer feedback.
> Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
> ---
>
> (no changes since v1)
Also not worth spinning the patch for, but your version history is
lacking for this patch.
The way patman works is that each patch should have its own version
history. Thus in patch #1 you could have had:
Series-changes: 2
- Adding "(newest rev)" for zombie entry description in qcom.yaml, as
requested by Douglas.
- Adding "dt-bindings: arm: qcom:" in bind patch ${SUBJECT}, as
requested by Douglas
- Changing Patch order, binding patch first and dt file second, as
requested by Douglas
Series-changes: 3
- Droping changing file path in description. v3. as requested by Matthias
Series-changes: 4
- Dropping the redundant 'DT binding for' as requested by Krzysztof
In patch #2 you would have done similar things but describe the things
that happened to _that_ patch. Make sense? Note that "Series-changes"
is different from some of the other tags in patman. Series-version
should only be listed in one patch. I believe Series-to and Series-cc
can be listed in multiple patches but they are all glommed together
into one list.
> Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
[0] https://lore.kernel.org/r/Y3zZWWCJ8aYphD7f@google.com/
next prev parent reply other threads:[~2022-11-28 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 9:44 [PATCH v5 1/2] dt-bindings: arm: qcom: Add zombie Owen Yang
2022-11-25 9:44 ` [PATCH v5 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie Owen Yang
2022-11-28 16:55 ` Matthias Kaehlcke
2022-11-28 16:58 ` Doug Anderson
2022-11-25 10:13 ` [PATCH v5 1/2] dt-bindings: arm: qcom: Add zombie Krzysztof Kozlowski
2022-11-28 16:58 ` Doug Anderson [this message]
2022-11-28 17:16 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VqXEONnSOyFLHcM4Z9+6+bVnqjbd_24M9LAoAsWy-L=A@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=abner.yen@ecs.corp-partner.google.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ecs.taipeikernel@gmail.com \
--cc=gavin.lee@ecs.corp-partner.google.com \
--cc=hunge@google.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@google.com \
--cc=moragues@google.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).