From: Doug Anderson <dianders@chromium.org>
To: John Youn <John.Youn@synopsys.com>, Felipe Balbi <balbi@ti.com>
Cc: "Yunzhi Li" <lyz@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Julius Werner" <jwerner@chromium.org>,
"Herrero, Gregory" <gregory.herrero@intel.com>,
"Kaukab, Yousaf" <yousaf.kaukab@intel.com>,
"Dinh Nguyen" <dinguyen@opensource.altera.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Ming Lei" <ming.lei@canonical.com>,
"Douglas Anderson" <dianders@chromium.org>,
"John Youn" <johnyoun@synopsys.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] usb: dwc2: host: Rewrite the microframe scheduler
Date: Mon, 9 Nov 2015 11:24:00 -0800 [thread overview]
Message-ID: <CAD=FV=VrcimjU8aeFemRQ9cO79XsoacHAzmHWRJN6nZtnipfDA@mail.gmail.com> (raw)
In-Reply-To: <1446861051-20135-1-git-send-email-dianders@chromium.org>
Hi,
On Fri, Nov 6, 2015 at 5:50 PM, Douglas Anderson <dianders@chromium.org> wrote:
> The old microframe scheduler was terribly hard to follow and (it seemed
> to me) that it had some bugs in it.
>
> Let's re-write it in a simpler, easier-to-read way. Hopefully this will
> work better.
>
> Note: no known problems are fixed by this patch, and in fact I can see
> very little impact of the microframe scheduler overall.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> drivers/usb/dwc2/hcd_queue.c | 72 ++++++++++++++++++++------------------------
> 1 file changed, 32 insertions(+), 40 deletions(-)
Self-NAKing this change.
I wrote up some test code to help visualize how things were scheduled.
That proved that the old function is pretty broken, but the new
function not only has a typo (using "i" instead of "j" in a few
places) but also suffers from some of the same problems as the old
function.
It might be easy to use the bitmap functions to implement this easily
/ properly. I'll see if I can do that.
-Doug
prev parent reply other threads:[~2015-11-09 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 1:50 [RFC PATCH] usb: dwc2: host: Rewrite the microframe scheduler Douglas Anderson
2015-11-09 19:24 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VrcimjU8aeFemRQ9cO79XsoacHAzmHWRJN6nZtnipfDA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=John.Youn@synopsys.com \
--cc=balbi@ti.com \
--cc=dinguyen@opensource.altera.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.herrero@intel.com \
--cc=heiko@sntech.de \
--cc=johnyoun@synopsys.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lyz@rock-chips.com \
--cc=ming.lei@canonical.com \
--cc=stern@rowland.harvard.edu \
--cc=yousaf.kaukab@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).