From: Doug Anderson <dianders@chromium.org>
To: Artur Petrosyan <Arthur.Petrosyan@synopsys.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
John Youn <John.Youn@synopsys.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes.
Date: Mon, 29 Apr 2019 10:43:15 -0700 [thread overview]
Message-ID: <CAD=FV=VtNUu0GyamvOv8x4rFHjFZdOaLMkFN=Rh0mJED08fW2Q@mail.gmail.com> (raw)
In-Reply-To: <SN1PR12MB2431C9312AD486935C9B728AA7390@SN1PR12MB2431.namprd12.prod.outlook.com>
Hi,
On Mon, Apr 29, 2019 at 5:05 AM Artur Petrosyan
<Arthur.Petrosyan@synopsys.com> wrote:
>
> > To add a bit of breadcrumbs, I did the rebase atop my patches and also
> > did some basic review of yours. Other than a few nits I think I found
> > at least one bug where you're unlocking a spinlock twice in the
> > partial power down case.
> Yeah thank you so much for the review it really helps to make
> conclusions on the implementations. I have tested those patches on
> HAPS-DX platform and have not got any problem. Hibernation and partial
> power down flows are working ok.
Do you happen to have any boards that have "OTG_EN_PWROPT = 0"? I'd
love testing of my patch series with that.
> > I continue to be convinced that the right thing to do is to finish
> > landing my series and then once you've spun yours atop mine we can
> > look at landing it.
> >
> > Here's all my picks atop Felipe's tree that show how I resolved
> > things: https://urldefense.proofpoint.com/v2/url?u=https-3A__chromium.googlesource.com_chromiumos_third-5Fparty_kernel_-2Blog_refs_sandbox_dianders_190426-2Ddwc2-2Dstuff&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=mdz-R9O5TUR_zXEeeCZO2341dvcwZro2cedCZzIIans&s=mVfBGtiMQg2XVHXmGCWcd584g0DYRH1JDVnEnJWE6P8&e=
> >
> >
> > -Doug
> >
>
> I will make my changes then will go ahead and rebase.
Thanks!
-Doug
next prev parent reply other threads:[~2019-04-29 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1555672441.git.arturp@synopsys.com>
[not found] ` <87k1fis1b5.fsf@linux.intel.com>
[not found] ` <SN1PR12MB2431EB450993E07730C3672FA73D0@SN1PR12MB2431.namprd12.prod.outlook.com>
2019-04-25 20:12 ` [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes Doug Anderson
2019-04-26 7:10 ` Artur Petrosyan
2019-04-26 16:01 ` Doug Anderson
2019-04-26 21:06 ` Doug Anderson
2019-04-29 12:05 ` Artur Petrosyan
2019-04-29 17:43 ` Doug Anderson [this message]
2019-04-29 8:44 ` Artur Petrosyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VtNUu0GyamvOv8x4rFHjFZdOaLMkFN=Rh0mJED08fW2Q@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=Arthur.Petrosyan@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=Minas.Harutyunyan@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).