linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l
@ 2020-11-20 20:09 Stephen Boyd
  2020-11-20 22:52 ` Doug Anderson
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2020-11-20 20:09 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson; +Cc: linux-kernel, linux-arm-msm, Douglas Anderson

This interrupt has an external pull-up so we don't need to pull it up
again. Drop the internal pull here. Note I don't think this really
changes anything, just noticed while looking at this irq pin.

Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index d48a75afdafb..3eb1ff2483be 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -1331,7 +1331,8 @@ pinmux {
 
 		pinconf {
 			pins = "gpio24";
-			bias-pull-up;
+			/* Has external pullup */
+			bias-disable;
 		};
 	};
 

base-commit: ead9f7d7ea9e20843e29e688b53859cea20044ee
prerequisite-patch-id: 239dd75c9c3d2ef544f95466280f296fc217c096
-- 
https://chromeos.dev


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l
  2020-11-20 20:09 [PATCH] arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l Stephen Boyd
@ 2020-11-20 22:52 ` Doug Anderson
  0 siblings, 0 replies; 2+ messages in thread
From: Doug Anderson @ 2020-11-20 22:52 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Andy Gross, Bjorn Andersson, LKML, linux-arm-msm

Hi,

On Fri, Nov 20, 2020 at 12:09 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> This interrupt has an external pull-up so we don't need to pull it up
> again. Drop the internal pull here. Note I don't think this really
> changes anything, just noticed while looking at this irq pin.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-20 22:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 20:09 [PATCH] arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l Stephen Boyd
2020-11-20 22:52 ` Doug Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).