From: Doug Anderson <dianders@chromium.org>
To: Johnny Chuang <johnny.chuang.emc@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
LKML <linux-kernel@vger.kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Harry Cutts <hcutts@chromium.org>,
Johnny Chuang <johnny.chuang@emc.com.tw>,
James Chen <james.chen@emc.com.tw>,
Jennifer Tsai <jennifer.tsai@emc.com.tw>,
Paul Liang <paul.liang@emc.com.tw>,
Jeff Chuang <jeff.chuang@emc.com.tw>,
Jingle <jingle.wu@emc.com.tw>
Subject: Re: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset
Date: Wed, 14 Apr 2021 08:28:49 -0700 [thread overview]
Message-ID: <CAD=FV=VvrWKKbLExpFaDLTDGTam3rbwd7CwTLVFdCY=_c7-eag@mail.gmail.com> (raw)
In-Reply-To: <1618276850-27178-1-git-send-email-johnny.chuang.emc@gmail.com>
Hi,
On Mon, Apr 12, 2021 at 6:20 PM Johnny Chuang
<johnny.chuang.emc@gmail.com> wrote:
>
> Fixes: 43b7029f475e ("HID: i2c-hid: Send power-on command after reset").
Note that the "Fixes" tag actually belongs down at the end. It also
shouldn't have a "." at the end. Presumably the maintainer can adjust
this when landing?
> For ELAN touchscreen, we found our boot code of IC was not flexible enough
> to receive and handle this command.
> Once the FW main code of our controller is crashed for some reason,
> the controller could not be enumerated successfully to be recognized
> by the system host. therefore, it lost touch functionality.
>
> Add quirk for skip send power-on command after reset.
> It will impact to ELAN touchscreen and touchpad on HID over I2C projects.
>
> Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>
This patch looks fine to me, thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I can confirm that after applying this patch I can recovery my borked
touchscreen (which got borked by a failed firmware update ages ago):
Tested-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2021-04-14 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 1:20 [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset Johnny Chuang
2021-04-13 17:29 ` Harry Cutts
2021-04-14 15:28 ` Doug Anderson [this message]
2021-04-23 7:54 ` Johnny.Chuang
2021-05-07 8:44 ` Johnny.Chuang
2021-05-07 13:38 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VvrWKKbLExpFaDLTDGTam3rbwd7CwTLVFdCY=_c7-eag@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hcutts@chromium.org \
--cc=james.chen@emc.com.tw \
--cc=jeff.chuang@emc.com.tw \
--cc=jennifer.tsai@emc.com.tw \
--cc=jingle.wu@emc.com.tw \
--cc=johnny.chuang.emc@gmail.com \
--cc=johnny.chuang@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.liang@emc.com.tw \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).