From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752325AbcEIPQs (ORCPT ); Mon, 9 May 2016 11:16:48 -0400 Received: from mail-vk0-f54.google.com ([209.85.213.54]:34249 "EHLO mail-vk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbcEIPQp (ORCPT ); Mon, 9 May 2016 11:16:45 -0400 MIME-Version: 1.0 In-Reply-To: <1462794377-6528-2-git-send-email-william.wu@rock-chips.com> References: <1462794377-6528-1-git-send-email-william.wu@rock-chips.com> <1462794377-6528-2-git-send-email-william.wu@rock-chips.com> Date: Mon, 9 May 2016 08:16:44 -0700 Message-ID: Subject: Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip From: Doug Anderson To: William Wu Cc: Greg Kroah-Hartman , Felipe Balbi , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Brian Norris , Kever Yang , Tao Huang , frank.wang@rock-chips.com, Eddie Cai , John Youn , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org William, On Mon, May 9, 2016 at 4:46 AM, William Wu wrote: > Signed-off-by: William Wu > --- > drivers/usb/dwc3/dwc3-of-simple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c > index 9743353..1f3665b 100644 > --- a/drivers/usb/dwc3/dwc3-of-simple.c > +++ b/drivers/usb/dwc3/dwc3-of-simple.c > @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = { > static const struct of_device_id of_dwc3_simple_match[] = { > { .compatible = "qcom,dwc3" }, > { .compatible = "xlnx,zynqmp-dwc3" }, > + { .compatible = "rockchip,dwc3" }, It is, of course, up to Felipe. ...but personally I'd prefer that things here be sorted alphabetically. Sorting things in a consistent manner tends to reduce merge conflicts as the list gets longer and also makes it easier to find things. -Doug