From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
patches@lists.linux.dev,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
chrome-platform@lists.linux.dev,
Guenter Roeck <groeck@chromium.org>,
Craig Hesling <hesling@chromium.org>,
Tom Hughes <tomhughes@chromium.org>,
Alexandru M Stan <amstan@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Benson Leung <bleung@chromium.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v5 3/3] dt-bindings: cros-ec: Add ChromeOS fingerprint binding
Date: Thu, 12 May 2022 16:44:51 -0700 [thread overview]
Message-ID: <CAD=FV=W4k8-Ab+diBic5rbannRr1ZKB=cdHNEOC3Emr0nyzQjQ@mail.gmail.com> (raw)
In-Reply-To: <20220512013921.164637-4-swboyd@chromium.org>
Hi,
On Wed, May 11, 2022 at 6:39 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> @@ -176,6 +189,37 @@ allOf:
> - reg
> - interrupts
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: google,cros-ec-fp
> + then:
> + properties:
> + '#address-cells': false
> + '#size-cells': false
> + typec: false
> + ec-pwm: false
> + keyboard-controller: false
> + proximity: false
> + codecs: false
> + cbas: false
> +
> + patternProperties:
> + "^i2c-tunnel[0-9]*$": false
> + "^regulator@[0-9]+$": false
> + "^extcon[0-9]*$": false
> +
> + required:
> + - reset-gpios
> + - boot0-gpios
> + - vdd-supply
> + else:
> + properties:
> + reset-gpios: false
> + boot0-gpios: false
> + vdd-supply: false
Wow, that's a huge pain to have to specify it this way, but I don't
know of any other way to make things happy and still have the
"google,cros-ec-spi" fallback that we decided on having in previous
versions.
> additionalProperties: false
>
> examples:
> @@ -231,4 +275,22 @@ examples:
> compatible = "google,cros-ec-rpmsg";
> };
> };
> +
> + - |
nit: all the other examples have a little "# For <blah>" comment
before them. It's not really necessary, but do we want one here to
match?
In any case, it seems OK to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2022-05-12 23:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 1:39 [PATCH v5 0/3] dt-bindings: cros-ec: Update for fingerprint devices Stephen Boyd
2022-05-12 1:39 ` [PATCH v5 1/3] dt-bindings: cros-ec: Fix a typo in description Stephen Boyd
2022-05-12 15:20 ` Guenter Roeck
2022-05-16 15:15 ` Rob Herring
2022-05-23 15:11 ` Lee Jones
2022-05-12 1:39 ` [PATCH v5 2/3] dt-bindings: cros-ec: Reorganize property availability Stephen Boyd
2022-05-12 23:44 ` Doug Anderson
2022-05-16 19:32 ` Stephen Boyd
2022-05-16 15:20 ` Rob Herring
2022-05-12 1:39 ` [PATCH v5 3/3] dt-bindings: cros-ec: Add ChromeOS fingerprint binding Stephen Boyd
2022-05-12 23:44 ` Doug Anderson [this message]
2022-05-16 15:20 ` Rob Herring
2022-05-16 19:23 ` Stephen Boyd
2022-05-18 16:13 ` Rob Herring
2022-05-18 19:56 ` Stephen Boyd
2022-05-19 19:48 ` Rob Herring
2022-06-06 3:33 ` [PATCH v5 0/3] dt-bindings: cros-ec: Update for fingerprint devices patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=W4k8-Ab+diBic5rbannRr1ZKB=cdHNEOC3Emr0nyzQjQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=hesling@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=patches@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tomhughes@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).