From: Doug Anderson <dianders@chromium.org>
To: Derek Basehore <dbasehore@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, "Tony Xie" <tony.xie@rock-chips.com>,
Chris <zyw@rock-chips.com>,
ayaka@soulik.info, "nickey.yang" <nickey.yang@rock-chips.com>,
郑舜乾 <zhengsq@rock-chips.com>,
"Klaus Goger" <klaus.goger@theobroma-systems.com>,
"Brian Norris" <briannorris@chromium.org>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk
Date: Fri, 16 Nov 2018 08:00:56 -0800 [thread overview]
Message-ID: <CAD=FV=W7sYY5n609erPpTxux+0Efad_0YpPkoVZB14Kqm=baXA@mail.gmail.com> (raw)
In-Reply-To: <20181116051719.23376-1-dbasehore@chromium.org>
Hi,
On Thu, Nov 15, 2018 at 9:17 PM Derek Basehore <dbasehore@chromium.org> wrote:
>
> This adds the xin32k clock to the RK3399 CPU. Even though it's not
> directly used, muxes will end up traversing the entire clk tree on
> calls to determine_rate if it doesn't exist.
>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
nit: I would have expected ${SUBJECT} to have v2 in it somewhere.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 99e7f65c1779..3d09472978f8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
Aww crud. I was at the airport yesterday and so I didn't notice that
you were touching rk3399, not rk3399-gru. This belongs in the gru
device tree file, not in the top level rk3399. As you have written
this it will break rk3399 boards that have an rk808 on them, AKA:
arch/arm64/boot/dts/rockchip/rk3399-ficus.dts:
arch/arm64/boot/dts/rockchip/rk3399-firefly.dts:
arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi:
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi:
-Doug
next prev parent reply other threads:[~2018-11-16 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 5:17 [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk Derek Basehore
2018-11-16 16:00 ` Doug Anderson [this message]
2018-11-16 17:39 ` dbasehore .
2018-11-16 18:23 ` Heiko Stübner
2018-11-16 18:23 ` Doug Anderson
2018-11-19 9:41 ` Heiko Stübner
2018-11-20 2:05 ` dbasehore .
-- strict thread matches above, loose matches on Subject: below --
2018-11-16 0:42 Derek Basehore
2018-11-16 5:03 ` Doug Anderson
2018-11-16 5:17 ` dbasehore .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=W7sYY5n609erPpTxux+0Efad_0YpPkoVZB14Kqm=baXA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=ayaka@soulik.info \
--cc=briannorris@chromium.org \
--cc=dbasehore@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nickey.yang@rock-chips.com \
--cc=robh+dt@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=zhengsq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).