From: Doug Anderson <dianders@chromium.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Ravi Kumar Bokka <rbokka@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
dhavalp@codeaurora.org, mturney@codeaurora.org,
sparate@codeaurora.org, c_rbokka@codeaurora.org,
mkurumel@codeaurora.org
Subject: Re: [RFC v2 1/3] dt-bindings: nvmem: Add devicetree bindings for qfprom-efuse
Date: Mon, 15 Jun 2020 07:27:40 -0700 [thread overview]
Message-ID: <CAD=FV=WGCvQTRHWX4Dvx+pTf010NbEzQMgcV4WDKQ6M8KO-cRw@mail.gmail.com> (raw)
In-Reply-To: <0ee1d7fa-0520-a347-6a55-6ab646284b1a@linaro.org>
Hi,
On Mon, Jun 15, 2020 at 3:44 AM Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
>
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - qcom,qfprom
> >
> > As per discussion in patch #1, I believe SoC compatible should be here
> > too in case it is ever needed. This is standard practice for dts
> > files for IP blocks embedded in an SoC. AKA, this should be:
> >
> > items:
> > - enum:
> > - qcom,apq8064-qfprom
> > - qcom,apq8084-qfprom
> > - qcom,msm8974-qfprom
> > - qcom,msm8916-qfprom
> > - qcom,msm8996-qfprom
> > - qcom,msm8998-qfprom
> > - qcom,qcs404-qfprom
> > - qcom,sc7180-qfprom
> > - qcom,sdm845-qfprom
>
>
> Above is not required for now in this patchset, as we can attach data at
> runtime specific to version of the qfprom.
>
> This can be added when required!
I'm OK with leaving off for this patchset. After we get everything
landed for blowing fuses then I can send out a separate patch where we
can debate the merits of adding the SoC-specific compatible strings.
:-) Sound good?
-Doug
next prev parent reply other threads:[~2020-06-15 14:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 9:47 [RFC v2 0/3] Add QTI QFPROM-Efuse driver support Ravi Kumar Bokka
2020-06-11 9:48 ` [RFC v2 1/3] dt-bindings: nvmem: Add devicetree bindings for qfprom-efuse Ravi Kumar Bokka
2020-06-11 12:18 ` Rajendra Nayak
2020-06-12 21:58 ` Rob Herring
2020-06-12 21:59 ` Doug Anderson
2020-06-12 23:15 ` Doug Anderson
2020-06-15 10:44 ` Srinivas Kandagatla
2020-06-15 14:17 ` Rob Herring
2020-06-15 14:27 ` Doug Anderson [this message]
2020-06-15 14:28 ` Srinivas Kandagatla
2020-06-11 9:48 ` [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support Ravi Kumar Bokka
2020-06-13 20:33 ` Doug Anderson
2020-06-15 10:44 ` Srinivas Kandagatla
2020-06-15 17:13 ` Doug Anderson
2020-06-17 14:54 ` Doug Anderson
2020-06-15 9:56 ` Srinivas Kandagatla
2020-06-11 9:48 ` [RFC v2 3/3] arm64: dts: qcom: sc7180: Add qfprom-efuse Ravi Kumar Bokka
2020-06-13 20:23 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WGCvQTRHWX4Dvx+pTf010NbEzQMgcV4WDKQ6M8KO-cRw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=c_rbokka@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dhavalp@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkurumel@codeaurora.org \
--cc=mturney@codeaurora.org \
--cc=rbokka@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sparate@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).