From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Philip Chen <philipchen@chromium.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs
Date: Tue, 14 Sep 2021 19:17:03 -0700 [thread overview]
Message-ID: <CAD=FV=WKQg-fU1jaSOh3RTa5HpSAiTzt2-Sycwt59uv1WemYxg@mail.gmail.com> (raw)
In-Reply-To: <CAE-0n53BXh3_6jEW5oTbPA-V=MSaN=RvqaU8uoY9GNOm-0Pv_g@mail.gmail.com>
Hi,
On Tue, Sep 14, 2021 at 5:29 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Philip Chen (2021-09-14 16:28:44)
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index e340af381e05..8d3e7a147170 100644
> > --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> > @@ -368,6 +396,12 @@ static int ps8640_probe(struct i2c_client *client)
> >
> > ps_bridge->page[PAGE0_DP_CNTL] = client;
> >
> > + ps_bridge->regmap[PAGE0_DP_CNTL] = devm_regmap_init_i2c(client, ps8640_regmap_config);
> > + if (IS_ERR(ps_bridge->regmap[PAGE0_DP_CNTL])) {
> > + return dev_err_probe(dev, PTR_ERR(ps_bridge->regmap[PAGE0_DP_CNTL]),
> > + "Error initting page 0 regmap\n");
>
> This one also doesn't return -EPROBE_DEFER? The dev_err_probe() should
> really only be used on "get" style APIs that can defer.
Any reason why you say that dev_err_probe() should only be used on
"get" style APIs that can defer? Even if an API can't return
-EPROBE_DEFER, using dev_err_probe() still (IMO) makes the code
cleaner and should be used for any error cases like this during probe.
Why?
* It shows the error code in a standard way for you.
* It returns the error code you passed it so you can make your error
return "one line" instead of 2.
Is there some bad thing about dev_err_probe() that makes it
problematic to use? If not then the above advantages should be a net
win, right?
-Doug
next prev parent reply other threads:[~2021-09-15 2:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 23:28 [PATCH v3 1/3] drm/bridge: parade-ps8640: Improve logging at probing Philip Chen
2021-09-14 23:28 ` [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs Philip Chen
2021-09-15 0:29 ` Stephen Boyd
2021-09-15 2:17 ` Doug Anderson [this message]
2021-09-15 2:50 ` Stephen Boyd
2021-09-15 16:41 ` Doug Anderson
2021-09-16 22:17 ` Stephen Boyd
2021-09-16 23:21 ` Doug Anderson
2021-09-17 6:12 ` Stephen Boyd
2021-09-17 15:02 ` Doug Anderson
2021-09-17 22:49 ` Philip Chen
2021-09-14 23:28 ` [PATCH v3 3/3] drm/bridge: parade-ps8640: Add support for AUX channel Philip Chen
2021-09-15 0:57 ` Stephen Boyd
2021-09-15 20:41 ` Philip Chen
2021-09-15 21:00 ` Fabio Estevam
2021-09-15 21:18 ` Philip Chen
2021-09-15 21:27 ` Doug Anderson
2021-09-16 20:15 ` Stephen Boyd
2021-09-16 20:30 ` Doug Anderson
2021-09-17 22:55 ` Philip Chen
2021-09-17 22:57 ` Philip Chen
2021-09-15 0:27 ` [PATCH v3 1/3] drm/bridge: parade-ps8640: Improve logging at probing Stephen Boyd
2021-09-17 22:43 ` Philip Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WKQg-fU1jaSOh3RTa5HpSAiTzt2-Sycwt59uv1WemYxg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=philipchen@chromium.org \
--cc=robert.foss@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).