From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4680C433E9 for ; Fri, 12 Mar 2021 21:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EACE64F76 for ; Fri, 12 Mar 2021 21:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235257AbhCLV3L (ORCPT ); Fri, 12 Mar 2021 16:29:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235227AbhCLV2k (ORCPT ); Fri, 12 Mar 2021 16:28:40 -0500 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 197E2C061574 for ; Fri, 12 Mar 2021 13:28:40 -0800 (PST) Received: by mail-qk1-x729.google.com with SMTP id s7so25868324qkg.4 for ; Fri, 12 Mar 2021 13:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CyAYeE6GJ7AAB1io1oL7YIRE2Sz07Daf/UvMuTr7W2c=; b=fSNCBIrGNaHWgDtwGWVa9gDETYtkK8/mwAXpNCO3xCJETCm+LMd7acUp2GSmnj7QAe Ctul4F1l8NInT3OOnPOG6ljLmZF4QOQqWntpWbvwfClqBqoVNzWEclCiiS9i89pbOcpd vaVgXjvPUOpa3oeeFNk2TTQqu5lEJT0bNzomQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CyAYeE6GJ7AAB1io1oL7YIRE2Sz07Daf/UvMuTr7W2c=; b=rG9j3p27ZgLn7KzmR3bWQjduJuDw7jZM691EI5A2ZLL4hoCf9nyrW9me5c/nmcsPEn C2x8pGlx1CUwwLtysVvX70EiOeTqVs0g5Y0faCj+LqF+zpPnDRsaNqHRNspLwWf2u/qt ENz43DAomu++tC+MJq1WniQF5JmDN+ndo6PONHAWHKLq394Ur24snFxdYf6keV7G5UiX zU4Jf9toRNBREju0LDPcLMs2QL9MoczrTlKovQk3U5XZmZAkkwemIanqplZETJu7lnBm eVIAhoigZqPsI4TBu+Dyv3BLgAJQANgiRTzoDTLLU2UBsgMA7v1z/D82WEgqPVlBvzKg E8sA== X-Gm-Message-State: AOAM531YNqR/U4y7fR/r3R1Oo5mTjsyh58hsDZ8Fayhq8fVSykwMFr/n SGqMrRLtF6kyr0SgRfefAV2DN+txpPLO1w== X-Google-Smtp-Source: ABdhPJxCi+T3gmWikI3tXMWs95aPfRAN5Er3z0vMeoHDnvTL3nKJZkyckTtzY9az1GUymaIEld+sPA== X-Received: by 2002:a37:5c42:: with SMTP id q63mr13820958qkb.213.1615584519092; Fri, 12 Mar 2021 13:28:39 -0800 (PST) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id z5sm4871764qtc.42.2021.03.12.13.28.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Mar 2021 13:28:38 -0800 (PST) Received: by mail-yb1-f182.google.com with SMTP id x19so26854303ybe.0 for ; Fri, 12 Mar 2021 13:28:38 -0800 (PST) X-Received: by 2002:a25:d3c5:: with SMTP id e188mr21573271ybf.345.1615584518203; Fri, 12 Mar 2021 13:28:38 -0800 (PST) MIME-Version: 1.0 References: <20210312160622.24165-1-srivasam@codeaurora.org> <20210312160622.24165-3-srivasam@codeaurora.org> In-Reply-To: <20210312160622.24165-3-srivasam@codeaurora.org> From: Doug Anderson Date: Fri, 12 Mar 2021 13:28:26 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz To: Srinivasa Rao Mandadapu Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rohit kumar , Srinivas Kandagatla , Stephen Boyd , Judy Hsiao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Mar 12, 2021 at 8:07 AM Srinivasa Rao Mandadapu wrote: > > This is a trgodor variant, required to have sound node variable > for coachz specific platform. > > Signed-off-by: Srinivasa Rao Mandadapu > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > index 4ad520f00485..7eaad739b6f9 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > @@ -89,6 +89,16 @@ &sn65dsi86_out { > data-lanes = <0 1 2 3>; > }; > > +&sound { > + compatible = "google,sc7180-coachz"; > + model = "sc7180-adau7002-max98357a"; > + audio-routing = "PDM_DAT", "DMIC"; > +}; > + > +&multimedia0_codec { > + sound-dai = <&adau7002>; > +}; > + Much nicer! The last nit is that "multimedia0_codec" is now sorted incorrectly. It starts with "m" so it shouldn't come after "s". Yes, I know that this rule means that these two things are no longer next to each other, but that's the rule we have right now. If it's important for you for them to sort together, I suppose you could change the label to "sound_multimedia0_codec" though that's a bit of a mouthful. I'll leave it up to you whether to rename (and keep the current ordering) or keep the name (and move the node). -Doug