From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E0EC43334 for ; Wed, 20 Jul 2022 15:07:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240235AbiGTPHd (ORCPT ); Wed, 20 Jul 2022 11:07:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232429AbiGTPHc (ORCPT ); Wed, 20 Jul 2022 11:07:32 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 300AC237D6 for ; Wed, 20 Jul 2022 08:07:31 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id tk8so22225173ejc.7 for ; Wed, 20 Jul 2022 08:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QLkLqL61DDqJ9IAVUdmTVDocJg5pLEqlAURJ5AHPPUk=; b=jwiuRcsVxReYTQwzNleS0OK+pJTpyysxB+6naxh1/qIV3RDFn0d/Gah6qlvxG7mYR0 +Ae6/nMY7OPLolxegD4LWlydgrTVuRzzVTAiuQHwCiE+AkUiVyb3/6ZBLWYAN2A6T8iR nsCrclsH10l+1H/sy8X2ZWmsfqB6oGWuSZZdQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QLkLqL61DDqJ9IAVUdmTVDocJg5pLEqlAURJ5AHPPUk=; b=l5yIxZTrS0C71G1FuZz1ajBU20u7eEBnatSxPySb5Hw1qvklUDIx1RN+cqQsj2Xibd 5fL/CqGhMSgQ1oUd1E/9PNv0qHDueqC6uq6vijyCeLMrf+zhA/cAjSxB94lCxhOQuv3v xNARBCWA75vHvMtqVpWOHNCbrJS0WSNmW6ecounGXm4RRl/P5N3Oulq/LcgmMIrG701v q1m6lgILqgPKP8oCL1kwzWEz7JlrltbqjZJ6kZMCP0BMGed2rTk3ZFn/rjaawg1Znyo0 jO9trkNfh/TAMYTqK02uuaXaz0lnS8jzFvRAMX821W8Ho9cNot0YlaQt4V7pvhpegYlb t5ig== X-Gm-Message-State: AJIora+xS173hntw67kDC0b0FUWTpPSWpRbnj0+TSn6LsxSEGH9/jW49 iQLL4o9eE1fMn8D6MEE1mg26spcMnQL99ZtHKfQ= X-Google-Smtp-Source: AGRyM1u9l0aFlxXjpJ2wzlayeq5LDOoMWSyuijFLK8ekwbtcPT+Pn/M1n7v5G0UzgGmTlmQvxbgf4g== X-Received: by 2002:a17:907:9803:b0:72e:ec55:b2a5 with SMTP id ji3-20020a170907980300b0072eec55b2a5mr26536973ejc.347.1658329649496; Wed, 20 Jul 2022 08:07:29 -0700 (PDT) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com. [209.85.128.42]) by smtp.gmail.com with ESMTPSA id p14-20020aa7cc8e000000b00435651c4a01sm12444857edt.56.2022.07.20.08.07.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 08:07:28 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id c187-20020a1c35c4000000b003a30d88fe8eso1547714wma.2 for ; Wed, 20 Jul 2022 08:07:28 -0700 (PDT) X-Received: by 2002:a05:600c:1549:b0:3a3:2aa2:6f60 with SMTP id f9-20020a05600c154900b003a32aa26f60mr2807595wmg.57.1658329648175; Wed, 20 Jul 2022 08:07:28 -0700 (PDT) MIME-Version: 1.0 References: <20220720073755.1.Ifab936517646b3876dd31b6e9b1b58a858529e57@changeid> <4cc6a276-4cbe-506a-6425-677c56469645@linaro.org> In-Reply-To: <4cc6a276-4cbe-506a-6425-677c56469645@linaro.org> From: Doug Anderson Date: Wed, 20 Jul 2022 08:07:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel To: Krzysztof Kozlowski Cc: Yunlong Jia , LKML , Henry Sun , Bob Moragues , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jul 20, 2022 at 12:46 AM Krzysztof Kozlowski wrote: > > On 20/07/2022 09:38, Yunlong Jia wrote: > > The difference between sku6 and sku4 is that there is no esim > > > > Signed-off-by: Yunlong Jia > > --- > > > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > > index 4dd18fbf20b6..aebeefdab27f 100644 > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > > @@ -410,6 +410,7 @@ properties: > > - description: Google Pazquel with LTE and Parade (newest rev) > > items: > > - const: google,pazquel-sku4 > > + - const: google,pazquel-sku6 > > This looks wrong, did you test it? Why do you think it's wrong? This patch is adding a second compatible string to an existing dts. The only difference between SKU4 and SKU6 is that one of them has the eSIM component stuffed and the other one doesn't. This need not be represented in the dts since the eSIM is automatically detected, but it was still stuffed as a SKU strapping so the factory could tell whether the missing eSIM was an error or intentional. This is just like the SKU0 vs. SKU2 difference. Other than the fact that this should be together in one series with the dts patch: Reviewed-by: Douglas Anderson