From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3093C433E9 for ; Tue, 12 Jan 2021 15:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9724623329 for ; Tue, 12 Jan 2021 15:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391733AbhALPfF (ORCPT ); Tue, 12 Jan 2021 10:35:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391715AbhALPfE (ORCPT ); Tue, 12 Jan 2021 10:35:04 -0500 Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8295CC061575 for ; Tue, 12 Jan 2021 07:34:13 -0800 (PST) Received: by mail-ua1-x92c.google.com with SMTP id j59so943584uad.5 for ; Tue, 12 Jan 2021 07:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qxCZhN0HPYWVbJAFHzviClBBvfiktQzKxiUuI/WHb64=; b=JwBBAAjWC19z8UsuWqxUc5kVg0wMb6EWFRHoz7kkGUngbEhRU+C6/MCHia57wDr8X9 Jd86Mt63DQEmW6eSaffdLzO7z7LiNnNGMHUe46zYzJcyQA6RGLKr4Kmg011Z0Emovi4/ at0IHPfJVaNEMbSJ/B0M5S6vGzvw1vRl459Eo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qxCZhN0HPYWVbJAFHzviClBBvfiktQzKxiUuI/WHb64=; b=shFvkIugjCiFoYJkMneVSTVpV0TtJArWkq0kuEUZbwv/F7T/7Xs6nIOugIWJYgteGx AATApRV/7J3xoI3HCJ5Er+Sa1pY7usEhDh18li+t6/5Kc8rhAupR7G47wbAcRjWT1hpo W4oBd7r7vC+Stex7fobareaNw6HHucWKgPZqa3O2n9uqlUvVoPUwqgZpapeoQKKoeseK aGClwlR0kg38Zhpc4Wu7BepHtfaSyBQ6TVt5fjOue/+z26BCZHPRxTNkkENAXVRHQkvx Ufhjr0QFqgNb0JPcWy8SIT5+7h+cY+oJCiUgoIdMh3QRr5NXwxr5h0cGaiChZ66xmozT IT6Q== X-Gm-Message-State: AOAM533G9gBCYLZO1RghrNbS1mge+g65xGXPe4bBO2P5S4y+WL/MfdvF 7H5MHJ2UJ7z7wCldPW2rl0MBrmbyqU4bpA== X-Google-Smtp-Source: ABdhPJwwIqzmFYvRuKbNJpn4uky1eDZLvO3f8aNt7/sh2WClA/lFfpKwI6kTS9tX0yU5pKL4szupdw== X-Received: by 2002:a9f:2213:: with SMTP id 19mr4065405uad.15.1610465652553; Tue, 12 Jan 2021 07:34:12 -0800 (PST) Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com. [209.85.221.174]) by smtp.gmail.com with ESMTPSA id z18sm480087vkd.13.2021.01.12.07.34.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jan 2021 07:34:11 -0800 (PST) Received: by mail-vk1-f174.google.com with SMTP id a6so692427vkb.8 for ; Tue, 12 Jan 2021 07:34:11 -0800 (PST) X-Received: by 2002:ac5:cde4:: with SMTP id v4mr4651199vkn.21.1610465651285; Tue, 12 Jan 2021 07:34:11 -0800 (PST) MIME-Version: 1.0 References: <20210112001301.687628-1-swboyd@chromium.org> In-Reply-To: <20210112001301.687628-1-swboyd@chromium.org> From: Doug Anderson Date: Tue, 12 Jan 2021 07:33:59 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] spi: spi-qcom-qspi: Use irq trigger flags from firmware To: Stephen Boyd Cc: Mark Brown , LKML , linux-spi , linux-arm-msm , Rajendra Nayak , Mukesh Kumar Savaliya , Akash Asthana Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jan 11, 2021 at 4:13 PM Stephen Boyd wrote: > > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. > > Cc: Douglas Anderson > Cc: Rajendra Nayak > Cc: Mukesh Kumar Savaliya > Cc: Akash Asthana > Signed-off-by: Stephen Boyd > --- > > Changes from v1: > * Rebased onto v5.11-rc1 > > drivers/spi/spi-qcom-qspi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Douglas Anderson