From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A02C433EF for ; Thu, 21 Jul 2022 13:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbiGUNhp (ORCPT ); Thu, 21 Jul 2022 09:37:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiGUNhm (ORCPT ); Thu, 21 Jul 2022 09:37:42 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 915327E33A for ; Thu, 21 Jul 2022 06:37:40 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id r6so2185987edd.7 for ; Thu, 21 Jul 2022 06:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8/cqmxcIHyGuuAd34yH5EGseYF2qIVCLxif3aKApjO8=; b=jQFRTYzVKfF7XyCxEjMIsHJZa8HQ0iHL21yIQj1Gy5IrYzGHlCXHfSFcxJI/9zfPHT zrlQ5VDaVZr9dhrwrr88VgBc/CzeknSxs3+qAQLyANBZAwoUZp3X4O3J+Zc5mvXCQ2yz U7eTH2JhxhZDOYg8zidV39R6zFx+zpmW4Of24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8/cqmxcIHyGuuAd34yH5EGseYF2qIVCLxif3aKApjO8=; b=kLZ6MWOcdU8dI62yb6ncQWSDBm2gjUF5ggeiyUt3IrhJuzyui1D1/S/hSinWa3eYnh IYVY5j4MNCRFsdKfwn9dLnpvqAL6XYEQ/iVNQMxlnx+HO+13BPCgDN+hEJ6IPVmDBIAZ 4+lL7BPyejlwOx4QmBuLu0FGJOpC0s9eL+kM5HnovbFZp5b0Jn81wAg4pu5+r+c8WSO/ fCxo1D7u9j54r58Iv/9911DDlGraXPWRWjczWSoZDSXrS0SjbhquuGfZ2anExzJLjvuX hZ5lFu0HUODFlwKkkSUhAg8PCn6mGKakmDcts1Wg/sV4Z+X0pHGhAmQgNxvZPvVJ7hTO 7kfw== X-Gm-Message-State: AJIora/gV2DtYsJ+vGc7JuXHfToIUcLWYhSi606jWmKQ1Kc6TxslMPj4 YE27mQ2JOdRlnRp4tkxV0Nqu5AGQO3lWkp/n X-Google-Smtp-Source: AGRyM1sZcnPiEiyLWv2VEVUm8+MwM1WFiGni8IRf84/pLabrFjnAnHH5AdC4TSMJ/31IDw5K7g4gzA== X-Received: by 2002:a05:6402:358d:b0:43a:c600:a678 with SMTP id y13-20020a056402358d00b0043ac600a678mr57453782edc.219.1658410658736; Thu, 21 Jul 2022 06:37:38 -0700 (PDT) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50]) by smtp.gmail.com with ESMTPSA id d32-20020a056402402000b00438ac12d6b9sm1029603eda.52.2022.07.21.06.37.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 06:37:37 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id id17so1065568wmb.1 for ; Thu, 21 Jul 2022 06:37:37 -0700 (PDT) X-Received: by 2002:a05:600c:2e48:b0:3a3:1ce3:3036 with SMTP id q8-20020a05600c2e4800b003a31ce33036mr7949226wmf.188.1658410656948; Thu, 21 Jul 2022 06:37:36 -0700 (PDT) MIME-Version: 1.0 References: <20220721033918.v3.1.I10519ca1bf88233702a90e296088808d18cdc7b1@changeid> <20220721033918.v3.2.I7ecbb7eeb58c5e6a33e32a3abf4d6874e6cb725c@changeid> In-Reply-To: <20220721033918.v3.2.I7ecbb7eeb58c5e6a33e32a3abf4d6874e6cb725c@changeid> From: Doug Anderson Date: Thu, 21 Jul 2022 06:37:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/2] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel To: Yunlong Jia Cc: LKML , Henry Sun , Bob Moragues , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jul 20, 2022 at 8:59 PM Yunlong Jia wrote: > > The difference between sku6 and sku4 is that there is no esim > > The different SKUs are: > > LTE with physical SIM _and_ eSIM > LTE with only a physical SIM > WiFi only > Both sku4 and sku6 are LTE SKUs. > One has the eSIM stuffed and one doesn't. > There is a single shared device tree for the two. > > Signed-off-by: Yunlong Jia > --- > > Changes in v3: > - Bindings and dts in the same series. > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file changed, 1 insertion(+) Not worth sending a new version for, but normally I expect the bindings to be patch #1 and the dts change to be patch #2. In any case: Reviewed-by: Douglas Anderson