linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: Cheng-Yi Chiang <cychiang@chromium.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: Fix return value of _set_load() stub
Date: Mon, 19 Nov 2018 09:23:24 -0800	[thread overview]
Message-ID: <CAD=FV=WTqUjivgD=v7u6fZfPt1vG-Dgv4kw7H3GvhMm7B3-vrA@mail.gmail.com> (raw)
In-Reply-To: <20181117031930.24011-1-broonie@kernel.org>

Hi,

On Fri, Nov 16, 2018 at 7:21 PM Mark Brown <broonie@kernel.org> wrote:
>
> The stub implementation of _set_load() returns a mode value which is
> within the bounds of valid return codes for success (the documentation
> just says that failures are negative error codes) but not sensible or
> what the actual implementation does.  Fix it to just return 0.
>
> Reported-by: Cheng-Yi Chiang <cychiang@chromium.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  include/linux/regulator/consumer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I had the same patch in my queue to send up.  Note that the
documentation of the function was changed in commit e39ce48f5362
("regulator: Rename regulator_set_optimum_mode") though that patch
didn't actually change the code in any significant way so presumably
the bug is from even before that.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

      reply	other threads:[~2018-11-19 17:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-17  3:19 [PATCH] regulator: Fix return value of _set_load() stub Mark Brown
2018-11-19 17:23 ` Doug Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=WTqUjivgD=v7u6fZfPt1vG-Dgv4kw7H3GvhMm7B3-vrA@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=broonie@kernel.org \
    --cc=cychiang@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).