From: Doug Anderson <dianders@chromium.org>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Olof Johansson <olof@lixom.net>,
Thomas Abraham <thomas.abraham@linaro.org>,
Padmavathi Venna <padma.v@samsung.com>,
Ben Dooks <ben-linux@fluff.org>,
Wolfram Sang <w.sang@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Karol Lewandowski <k.lewandowsk@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [REPOST PATCH 2/2] i2c: pxa: Use i2c-core to get bus number now
Date: Mon, 14 Jan 2013 10:52:32 -0800 [thread overview]
Message-ID: <CAD=FV=WXx6mdj5HBmPcxKPvQ0TeHSwmmzFmwTvrOqZ2qAthvpg@mail.gmail.com> (raw)
In-Reply-To: <50F08E44.3050500@gmail.com>
Sylwester,
Thanks for the review...
On Fri, Jan 11, 2013 at 2:12 PM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
>> - ret = of_alias_get_id(np, "i2c");
>> - if (ret< 0) {
>> - dev_err(&pdev->dev, "failed to get alias id, errno %d\n",
>> ret);
>> - return ret;
>> - }
>> - pdev->id = ret;
>> + pdev->id = -1;
>
>
> I think assignments like this are illegal. At this point the device is
> already registered and modifying pdev->id can cause issues at the core
> code.
Good catch. I think the old code is just as illegal since it was also
assigning to pdev->id, but I'm happy to spin the patch.
> It might be better to have the bus number stored in struct pxa_i2c,
> initialized with pdev->id value for non-dt and now with -1 for dt case.
I'll just init i2c->adap.nr before calling i2c_pxa_probe_dt(). Then
i2c_pxa_probe_dt() can adjust the number. Hopefully this is OK.
> I realize it is not something your patch is intended to deal with,
> but since you're touching this code maybe it's worth to fix that issue
> as well ?
Sure, I've spun it. While doing this I realized a few other issues
relating to the ID number. Specifically:
* We were using the id (as %u) when creating 'i2c->adap.name'. This
probably gave a very nonsensical ID. I'm just going to remove the
device number from the adap.name. That matches what i2c-s3c2410.c
does. As far as I can tell the adap.name isn't actually used for
much.
* The name was being used in request_irq(). I've changed this to be
like i2c-s3c2410 and use dev_name(). On my current board that means
that the name comes from the table in of_platform_populate(). ...but
that table is supposed to be going away. If I remove that i2c parts
of that table I get names like '12c60000.i2c', which should be fine
for passing to request_irq().
-Doug
next prev parent reply other threads:[~2013-01-14 18:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 22:27 [PATCH 1/2] ARM: EXYNOS: Add aliases for i2c controller for exynos4 Doug Anderson
2012-11-20 22:27 ` [PATCH 2/2] i2c: s3c2410: Get the i2c bus number from alias id Doug Anderson
2012-11-21 4:09 ` Mark Brown
2012-11-21 18:33 ` Doug Anderson
2012-11-22 6:56 ` Kukjin Kim
2012-11-21 9:43 ` Kukjin Kim
[not found] ` <1353522362-25519-1-git-send-email-dianders@chromium.org>
2012-11-21 18:26 ` [PATCH 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present Doug Anderson
2012-12-05 1:45 ` Haojian Zhuang
2013-01-11 17:57 ` [REPOST PATCH 0/2] Add automatic bus number support for i2c busses with device tree Doug Anderson
2013-01-11 17:57 ` [REPOST PATCH 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present Doug Anderson
2013-01-14 18:53 ` [PATCH v2 0/2] Add automatic bus number support for i2c busses with device tree Doug Anderson
2013-01-14 18:53 ` [PATCH v2 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present Doug Anderson
2013-01-15 6:34 ` Olof Johansson
2013-02-10 12:19 ` Wolfram Sang
2013-02-12 0:48 ` Doug Anderson
2013-01-14 18:53 ` [PATCH v2 2/2] i2c: pxa: Use i2c-core to get bus number now Doug Anderson
2013-01-11 17:57 ` [REPOST PATCH " Doug Anderson
2013-01-11 22:12 ` Sylwester Nawrocki
2013-01-14 18:52 ` Doug Anderson [this message]
2012-11-21 18:26 ` [PATCH " Doug Anderson
2012-12-05 1:45 ` Haojian Zhuang
2012-11-21 7:25 ` [PATCH 1/2] ARM: EXYNOS: Add aliases for i2c controller for exynos4 Olof Johansson
2012-11-21 9:43 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WXx6mdj5HBmPcxKPvQ0TeHSwmmzFmwTvrOqZ2qAthvpg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=haojian.zhuang@gmail.com \
--cc=k.lewandowsk@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=padma.v@samsung.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=thomas.abraham@linaro.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).