From: Doug Anderson <dianders@google.com>
To: yangcong <yangcong5@huaqin.corp-partner.google.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v4 3/4] drm/panel: support for BOE and INX video mode panel
Date: Mon, 30 Aug 2021 09:17:35 -0700 [thread overview]
Message-ID: <CAD=FV=WcvanAAjWix=qv=irMr_KfhTNQW+Hgauwcs7=03510FA@mail.gmail.com> (raw)
In-Reply-To: <20210830023849.258839-4-yangcong5@huaqin.corp-partner.google.com>
Hi,
On Sun, Aug 29, 2021 at 7:39 PM yangcong
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> Support for these two panels fits in nicely with the existing
> panel-boe-tv101wum-nl6 driver as suggested by Sam [1]. The main things
> we needed to handle were:
> a) These panels need slightly longer delays in two places. Since these
> new delays aren't much longer, let's just unconditionally increase
> them for the driver.
> b) One of these two panels doesn't support DSI HS mode so this patch
> adds a flag for a panel to disable that.
>
> [1] https://lore.kernel.org/r/YSPAseE6WD8dDRuz@ravnborg.org/
>
> Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
> ---
> .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 915 +++++++++++++++++-
> 1 file changed, 912 insertions(+), 3 deletions(-)
This looks fine to me now.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I'm happy to help land this series or for others to land it. For now
my plan is to let them sit for a couple of weeks and if there is
silence I will plan to land them in drm-misc-next. I'm happy to land
earlier with an Ack or I'm happy to step back if someone else wants to
take charge. ;-)
-Doug
next prev parent reply other threads:[~2021-08-30 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 2:38 [v4 0/4] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail yangcong
2021-08-30 2:38 ` [v4 1/4] " yangcong
2021-08-30 2:38 ` [v4 2/4] dt-bindings: " yangcong
2021-08-30 2:38 ` [v4 3/4] drm/panel: support for BOE and INX video mode panel yangcong
2021-08-30 16:17 ` Doug Anderson [this message]
2021-08-30 2:38 ` [v4 4/4] dt-bindngs: display: panel: Add BOE and INX panel bindings yangcong
2021-08-31 22:32 ` Rob Herring
2021-09-08 14:45 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WcvanAAjWix=qv=irMr_KfhTNQW+Hgauwcs7=03510FA@mail.gmail.com' \
--to=dianders@google.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).