From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70702C56201 for ; Fri, 20 Nov 2020 17:50:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF30B22240 for ; Fri, 20 Nov 2020 17:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="V1Y5a3dY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729185AbgKTRuy (ORCPT ); Fri, 20 Nov 2020 12:50:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728771AbgKTRux (ORCPT ); Fri, 20 Nov 2020 12:50:53 -0500 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52F8FC0613CF for ; Fri, 20 Nov 2020 09:50:53 -0800 (PST) Received: by mail-vs1-xe41.google.com with SMTP id v8so4955525vso.2 for ; Fri, 20 Nov 2020 09:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TOtOZIdB1J63uMVqmafZXssnYnw/QhcY3B9kUUaTAQE=; b=V1Y5a3dYeL7JPuo75mNvRhJBHLwVWgvC9S8Ms49FQmNLUJlvKpEU+blayiNdldDUJ+ wfDjYdxoQq2wFuX5+qp7waGd9RBvqUSW7X9FXoZj1aaG0typlIwmF9PXaW3zUNTkul5H vGAgtvZGd/AEjE25ldkEPQJMe81DAgH+szGds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TOtOZIdB1J63uMVqmafZXssnYnw/QhcY3B9kUUaTAQE=; b=GdUS5DqMoRqIa6+nNiJBn9d1JaF6qM5hnZBKCBltvE8fOQGzsC6bh3Aq4c27k4bV/8 ZhBZne1DDI4bXqCe112rwNF9Z2OfAcG8PwSk6n6GykxrbBG34AASJ+kb3wTNend25Dou GliQbURElAX8L1z6hvto6XUbMXVHUfDBzqfc0JtRUsK6QURjODWQueTZCHwFA+1QJyak pJ8Uqo5VxFK7L2bXtWQyCsLKVN2noeP54JMM3dSrdJDI6rcc4JcDGaWtiuEYeLmlpko9 /BIRZYetGkZyJ6W+GpCvALOdtYq7O8+FaEWyHz5uyeXh6S+aoR5A9/2payF+JWE0zyUx WuUg== X-Gm-Message-State: AOAM530lMns1xx8hKPy+Ak8u1mbfvIFNFcI+A5rKAKg6vY9uCfr9DEES Xv81mPfSpMrn76B4301ndxu2CsZNJzGHUA== X-Google-Smtp-Source: ABdhPJztku4ba6oFNzFcF2rrgYLyM/Mp5ah2INEbY3OusPJCTAIuoCtS1NpvrJvom0pwNFBC40o1Ww== X-Received: by 2002:a67:f243:: with SMTP id y3mr13783746vsm.56.1605894652211; Fri, 20 Nov 2020 09:50:52 -0800 (PST) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com. [209.85.217.46]) by smtp.gmail.com with ESMTPSA id m205sm476501vkm.9.2020.11.20.09.50.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2020 09:50:51 -0800 (PST) Received: by mail-vs1-f46.google.com with SMTP id r14so5425068vsa.13 for ; Fri, 20 Nov 2020 09:50:51 -0800 (PST) X-Received: by 2002:a67:4242:: with SMTP id p63mr13264633vsa.34.1605894650734; Fri, 20 Nov 2020 09:50:50 -0800 (PST) MIME-Version: 1.0 References: <20201120074508.3236616-1-swboyd@chromium.org> In-Reply-To: <20201120074508.3236616-1-swboyd@chromium.org> From: Doug Anderson Date: Fri, 20 Nov 2020 09:50:38 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add prox sensor to LTE sku Lazor boards To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , LKML , linux-arm-msm , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Nov 19, 2020 at 11:45 PM Stephen Boyd wrote: > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts > @@ -13,6 +13,14 @@ / { > compatible = "google,lazor-rev1-sku0", "google,lazor-rev2-sku0", "qcom,sc7180"; > }; > > +&ap_sar_sensor { > + status = "okay"; > +}; > + > +&ap_sar_sensor_i2c { > + status = "okay"; Technically you don't need to mark the i2c bus as "okay" upstream because it's already "okay" in "sc7180-trogdor.dtsi". ...or perhaps you should add a patch that changes that and makes us match downstream. ;-)