linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: "Benson Leung" <bleung@chromium.org>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	"Alexandru M Stan" <amstan@chromium.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Simon Glass" <sjg@chromium.org>,
	"Brian Norris" <briannorris@chromium.org>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Ryan Case" <ryandcase@chromium.org>,
	"Randall Spangler" <rspangler@chromium.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority
Date: Wed, 3 Apr 2019 14:08:40 -0700	[thread overview]
Message-ID: <CAD=FV=Whd4upxDDOrmVt=HgjEiGNuL2FccOfezpAFsy5yB55JA@mail.gmail.com> (raw)
In-Reply-To: <20190403210436.GS112750@google.com>

Hi,

On Wed, Apr 3, 2019 at 2:04 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> > +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev,
>
> nit: the fact that a high priority workqueue is used is an
> implementation detail, since the driver has no function to perform a
> transfer with 'normal'/low priority there is no need to distinguish
> between the two cases. In this sense I'd be inclined to remove the
> 'high_pri' from the function names.
>
> Sorry for not mentioning this earlier, I focussed on other
> details, anyway it's just a nit.

I still kinda like having the "high_pri" in there since the point of
this function is to transfer the work onto the high priority
workqueue.  It's not an exported function so having the implementation
detail leak into the name isn't a bad thing, is it?  ...so unless
someone else thinks the name should change or you feel strongly about
it I won't plan to change the name.

Thanks!

-Doug

  reply	other threads:[~2019-04-03 21:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 20:31 [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority Douglas Anderson
2019-04-03 21:04 ` Matthias Kaehlcke
2019-04-03 21:08   ` Doug Anderson [this message]
2019-04-03 21:19     ` Matthias Kaehlcke
2019-04-04 15:00       ` Enric Balletbo i Serra
2019-04-12  1:27 ` Brian Norris
2019-04-12  9:23   ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=Whd4upxDDOrmVt=HgjEiGNuL2FccOfezpAFsy5yB55JA@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=amstan@chromium.org \
    --cc=bleung@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mka@chromium.org \
    --cc=rspangler@chromium.org \
    --cc=ryandcase@chromium.org \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).