From: Doug Anderson <dianders@chromium.org>
To: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Clark <robdclark@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
quic_kalyant <quic_kalyant@quicinc.com>,
"Abhinav Kumar (QUIC)" <quic_abhinavk@quicinc.com>,
"Kuogee Hsieh (QUIC)" <quic_khsieh@quicinc.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
quic_vproddut <quic_vproddut@quicinc.com>,
quic_aravindh@quicinc.com
Subject: Re: [PATCH v6 5/8] drm/msm/dp: prevent multiple votes for dp resources
Date: Thu, 31 Mar 2022 16:23:05 -0700 [thread overview]
Message-ID: <CAD=FV=Wn-XypjRcw-D0VtBHZbuTz=RHiMq6RCHCa=CWmZM42nQ@mail.gmail.com> (raw)
In-Reply-To: <1648656179-10347-6-git-send-email-quic_sbillaka@quicinc.com>
Hi,
On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti
<quic_sbillaka@quicinc.com> wrote:
>
> The aux_bus support with the dp_display driver will enable the dp
> resources during msm_dp_modeset_init. The host_init has to return early
> if the core is already initialized to prevent putting an additional vote
> for the dp controller resources.
>
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
I'm not a huge fan of this but I'll leave it up to Dmitry. In general
it feels like there should be _a_ place that enables these resources.
Checks like this make it feel like we just scattershot enabling
resources in a bunch of random places instead of coming up with the
design for enabling them in the right place.
In any case, if we do end up landing this patch, it sure feels like it
needs to move earlier in the patch series, right? This patch shouldn't
hurt even without the other patches in the series but if you apply the
earlier patches in the series without this one then you'll have a bug,
right? That means this needs to come earlier.
-Doug
next prev parent reply other threads:[~2022-03-31 23:30 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 16:02 [PATCH v6 0/8] Add support for the eDP panel over aux_bus Sankeerth Billakanti
2022-03-30 16:02 ` [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus Sankeerth Billakanti
2022-03-30 23:19 ` Dmitry Baryshkov
2022-03-31 0:33 ` Doug Anderson
2022-03-31 23:22 ` Doug Anderson
2022-04-02 10:37 ` Dmitry Baryshkov
2022-04-02 17:06 ` Doug Anderson
2022-04-02 20:26 ` Dmitry Baryshkov
2022-04-04 20:53 ` Doug Anderson
2022-04-05 12:53 ` Dmitry Baryshkov
2022-04-05 17:02 ` Doug Anderson
2022-04-05 17:36 ` Dmitry Baryshkov
2022-04-05 18:11 ` Doug Anderson
2022-04-07 14:19 ` Sankeerth Billakanti (QUIC)
2022-04-07 17:07 ` Doug Anderson
2022-04-07 20:11 ` Abhinav Kumar
2022-04-07 20:47 ` Doug Anderson
2022-04-07 22:03 ` Abhinav Kumar
2022-04-07 23:34 ` Doug Anderson
2022-04-07 23:46 ` Dmitry Baryshkov
2022-04-08 0:21 ` Doug Anderson
2022-04-08 12:19 ` Dmitry Baryshkov
2022-04-08 13:43 ` Doug Anderson
2022-04-08 14:58 ` Dmitry Baryshkov
2022-04-08 17:23 ` Abhinav Kumar
2022-04-07 23:35 ` Dmitry Baryshkov
2022-04-08 0:20 ` Doug Anderson
2022-04-08 12:13 ` Dmitry Baryshkov
2022-04-08 13:56 ` Doug Anderson
2022-04-08 14:17 ` Dmitry Baryshkov
2022-03-30 16:02 ` [PATCH v6 2/8] drm/msm/dp: wait for hpd high before aux transaction Sankeerth Billakanti
2022-03-31 23:22 ` Doug Anderson
2022-04-04 12:43 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Sankeerth Billakanti
2022-03-31 23:22 ` Doug Anderson
2022-04-04 12:56 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts Sankeerth Billakanti
2022-03-30 22:16 ` Dmitry Baryshkov
2022-03-31 5:53 ` Sankeerth Billakanti (QUIC)
2022-03-31 10:10 ` Dmitry Baryshkov
2022-03-31 11:04 ` Sankeerth Billakanti
2022-03-31 11:06 ` Dmitry Baryshkov
2022-04-04 17:56 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 5/8] drm/msm/dp: prevent multiple votes for dp resources Sankeerth Billakanti
2022-03-31 23:23 ` Doug Anderson [this message]
2022-04-08 16:14 ` Dmitry Baryshkov
2022-04-08 17:12 ` Sankeerth Billakanti
2022-04-08 18:02 ` Dmitry Baryshkov
2022-03-30 16:02 ` [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot Sankeerth Billakanti
2022-03-31 23:23 ` Doug Anderson
2022-04-04 13:52 ` Sankeerth Billakanti (QUIC)
2022-04-04 21:13 ` Dmitry Baryshkov
2022-04-07 12:40 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd Sankeerth Billakanti
2022-03-31 23:23 ` Doug Anderson
2022-04-04 18:32 ` Sankeerth Billakanti (QUIC)
2022-04-04 21:15 ` Dmitry Baryshkov
2022-04-07 12:41 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp Sankeerth Billakanti
2022-03-30 22:08 ` Dmitry Baryshkov
2022-03-31 6:02 ` Sankeerth Billakanti (QUIC)
2022-03-31 23:24 ` Doug Anderson
2022-04-04 18:20 ` Sankeerth Billakanti (QUIC)
2022-04-04 21:29 ` Dmitry Baryshkov
2022-04-07 14:05 ` Sankeerth Billakanti (QUIC)
2022-04-08 12:08 ` Dmitry Baryshkov
2022-04-08 15:50 ` Sankeerth Billakanti
2022-04-08 16:47 ` Dmitry Baryshkov
2022-04-08 17:38 ` Sankeerth Billakanti
2022-04-08 18:06 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Wn-XypjRcw-D0VtBHZbuTz=RHiMq6RCHCa=CWmZM42nQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_aravindh@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).