From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E858C433DB for ; Wed, 6 Jan 2021 16:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29E7D23134 for ; Wed, 6 Jan 2021 16:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727633AbhAFQpA (ORCPT ); Wed, 6 Jan 2021 11:45:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbhAFQo7 (ORCPT ); Wed, 6 Jan 2021 11:44:59 -0500 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B80C06134C for ; Wed, 6 Jan 2021 08:44:19 -0800 (PST) Received: by mail-vs1-xe32.google.com with SMTP id x4so2084602vsp.7 for ; Wed, 06 Jan 2021 08:44:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tTDfLxUkFhfwS50KBXMNM9ZHcsAJTAU0wgDhHJKxUrw=; b=kAT4LDRfAvqRTBm/OHK9G1+UWr19HsI1gTt5otkoJU/K+hCsNF1IoD7GgTBAbAeQdS mEJHHroEq4QT8jXtCXGSk0sBwPFw4Owu4zC2VXQCGubIIqm/2f0V8wp5LL898Whyo4I0 +XPwKOGT/wT2x5VhAwFJ593EkO/BQWenH/Uq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tTDfLxUkFhfwS50KBXMNM9ZHcsAJTAU0wgDhHJKxUrw=; b=FM7F2CHQVqDfS6R75MKPBdbBJzYPONFwG9pyAcqmxfefzUewDUYlJAwv5kyGnkG6Eq c3jqB4mbz3Ixs9wZRbovdPnHqQt4fffJUbRLfVMUnL6u07XiQJFUh6M0xVC88XZEN12L GACbzDoj9SJThaTOJgz2HJV2YPnx//FuBDOzeT1bkq164fLI6WGnUCI9TSil756cnYlb xlhrPCmZIHIFFU7JMSL0KCXwkvPRnmmvB/IvJZzB6yTvyjW7t410H9mOm83ucKT9nvKS qb2qUuuF5i2uTei1bYYft5RcISrWNsBWsbfQCtzA+BB8VYNZSSh5SLTKp7WIi/dANfq/ Y3vg== X-Gm-Message-State: AOAM533QcY7WeDNGDAUPL4HrWQOkmNfJacY1/3z0F6dTEWrJW9igklU2 bvz0nryt65yTmYorLhSeykn0pFK94L7bOQ== X-Google-Smtp-Source: ABdhPJxCGmRYMnpsU7MuKqpnRUE8AW2ZjWjZOrSt7Mn1iSCc6Yr6tsNZZlr4LS6VD9NDjF7ZFxYfxw== X-Received: by 2002:a67:fc87:: with SMTP id x7mr3720123vsp.38.1609951458561; Wed, 06 Jan 2021 08:44:18 -0800 (PST) Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com. [209.85.222.48]) by smtp.gmail.com with ESMTPSA id j192sm451834vkc.17.2021.01.06.08.44.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 08:44:17 -0800 (PST) Received: by mail-ua1-f48.google.com with SMTP id f16so1258639uav.12 for ; Wed, 06 Jan 2021 08:44:16 -0800 (PST) X-Received: by 2002:ab0:2e99:: with SMTP id f25mr4254458uaa.104.1609951456419; Wed, 06 Jan 2021 08:44:16 -0800 (PST) MIME-Version: 1.0 References: <20201211222448.2115188-1-dianders@chromium.org> <20201211142412.v8.4.If41b7d621633b94d56653c6d53f5f89c5274de7b@changeid> In-Reply-To: <20201211142412.v8.4.If41b7d621633b94d56653c6d53f5f89c5274de7b@changeid> From: Doug Anderson Date: Wed, 6 Jan 2021 08:44:05 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core To: Jiri Kosina , Benjamin Tissoires , Greg Kroah-Hartman , Dmitry Torokhov Cc: Hans de Goede , "open list:HID CORE LAYER" , Kai-Heng Feng , Rob Herring , Stephen Boyd , Andrea Borgia , Jiri Kosina , Masahiro Yamada , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Dec 11, 2020 at 2:25 PM Douglas Anderson wrote: > > +static const struct goodix_i2c_hid_timing_data goodix_gt7375p_timing_data = { > + .post_power_delay_ms = 10, > + .post_gpio_reset_delay_ms = 120, As I've been going through my holiday email I found that Goodix has released a new datasheet (datasheet rev 0.6 from 2020-12-11) where this moves from 120 ms to 180 ms. Sigh. I'm hoping that we can just land it with the 120 though and then I'll send a follow-up patch to change to 180. This will avoid spamming everyone with a v9 of the patch series. Please yell if there are any objections to that plan. I'd also be fine if you wanted to just change it to 180 when landing it. Thanks much! -Doug