linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Michael Niewoehner <linux@mniewoehner.de>
Cc: John Youn <johnyoun@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
	Caesar Wang <caesar.upstream@gmail.com>,
	Tao Huang <huangtao@rock-chips.com>,
	Remi Pommarel <repk@triplefau.lt>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Julius Werner <jwerner@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()
Date: Fri, 4 Mar 2016 17:09:41 -0800	[thread overview]
Message-ID: <CAD=FV=X5QvsK9GHzxe1n4k7YdwsDOkGAVonT1+uJLKGyyoOvVQ@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=Xj=LKRsoORkjWfAwEzjY84R+=QBfOqLBgrUGyDmfN97g@mail.gmail.com>

Hi,

On Fri, Mar 4, 2016 at 4:33 PM, Doug Anderson <dianders@chromium.org> wrote:
> Michael,
>
> On Fri, Mar 4, 2016 at 4:09 PM, Michael Niewoehner <linux@mniewoehner.de> wrote:
>>>> From testing and trying to make sense of the documentation, it appears
>>>> that a 10 ms delay is needed after resetting the core to make sure that
>>>> everything is stable and consistent.  Let's add it.
>>>>
>>>> In my testing (on rk3288) this allows us to revert commit
>>>> 192cb07f7928 ("usb: dwc2: Fix probe problem on bcm2835").  Though I
>>>> could never reproduce the problems on my board, this might also allow us
>>>> to revert commit bd84f4ae9986 ("usb: dwc2: Add extra delay when forcing
>>>> dr_mode").
>>>>
>>>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>>>
>>> Tested-by: Michael Niewoehner <linux@mniewoehner.de>
>
> Thanks!  That's great news!
>
>
>>> I’m a bit confused since git log says bd84f4ae9986 has been merged in 62718e304aa6 but looking at drivers/usb/dwc2/core.c it seems the patch has not been applied anyways ...
>>> However, I tested you your two patches with „magically reverted“ bd84f4ae9986 (msleep 50) on rk3188.
>>> The sdcard keeps being detected and boots just fine.
>> I meant usb stick of course… too much sdcards in my head today \o/.
>
> Odd.  It looks to be there for me...
>
> $ git checkout 62718e304aa6
> HEAD is now at 62718e304aa6... Merge tag 'usb-4.5-rc6' of
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
>
> $ git grep -C3 "NOTE: This is required" -- drivers/usb/dwc2/core.c
> drivers/usb/dwc2/core.c-        }
> drivers/usb/dwc2/core.c-
> drivers/usb/dwc2/core.c-        /*
> drivers/usb/dwc2/core.c:         * NOTE: This is required for some
> rockchip soc based
> drivers/usb/dwc2/core.c-         * platforms.
> drivers/usb/dwc2/core.c-         */
> drivers/usb/dwc2/core.c-        msleep(50);

For anyone playing along at home, please see
<http://article.gmane.org/gmane.linux.usb.general/138355>.

-Doug

  reply	other threads:[~2016-03-05  1:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 18:23 [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset() Douglas Anderson
2016-03-04 18:23 ` [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835" Douglas Anderson
2016-03-04 22:54   ` Michael Niewoehner
2016-03-07 18:40   ` Stefan Wahren
2016-03-07 21:30     ` Doug Anderson
2016-03-08 17:49       ` Stefan Wahren
2016-03-09 19:01       ` Stefan Wahren
2016-03-09 19:06         ` Doug Anderson
2016-03-10 19:14           ` John Youn
2016-03-16 18:28             ` John Youn
2016-03-18 23:14               ` Stefan Wahren
2016-03-19  2:17                 ` Eric Anholt
2016-03-19  7:44                   ` Martin Sperl
2016-03-19  9:52                     ` Stefan Wahren
2016-03-19 10:10                       ` Martin Sperl
2016-03-19 12:09                         ` Stefan Wahren
2016-03-19  9:45                   ` Stefan Wahren
2016-03-19  5:21               ` Doug Anderson
2016-03-22 19:26                 ` John Youn
2016-03-22 19:44                   ` Doug Anderson
2016-03-22 20:37                     ` John Youn
2016-03-24  6:18                     ` John Youn
2016-03-04 22:54 ` [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset() Michael Niewoehner
2016-03-05  0:09   ` Michael Niewoehner
2016-03-05  0:33     ` Doug Anderson
2016-03-05  1:09       ` Doug Anderson [this message]
2016-03-05 20:41       ` Michael Niewoehner
2016-03-06  1:38         ` Doug Anderson
2016-03-04 23:46 ` Karl Palsson
2016-03-05  0:36   ` Doug Anderson
2016-03-04 23:52 ` Sergei Shtylyov
2016-03-05  2:23 ` John Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=X5QvsK9GHzxe1n4k7YdwsDOkGAVonT1+uJLKGyyoOvVQ@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=balbi@kernel.org \
    --cc=caesar.upstream@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=johnyoun@synopsys.com \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@mniewoehner.de \
    --cc=repk@triplefau.lt \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).